-
-
Notifications
You must be signed in to change notification settings - Fork 471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support auto generating release notes #179
Conversation
👍 to this - I'm looking to automate a bit more of my release workflows and this would be an excellent addition. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. Were you able to run this branch in a workflow to verify it works?
I didn't verify the change but I can later today. |
Just did a couple releases in a test repo and the change looks to work. This is the workflow used: on:
push:
tags:
- "v*.*.*"
permissions:
contents: write
jobs:
release:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2.4.0
- uses: xt0rted/action-gh-release@testing
with:
generate_release_notes: true The release created: I removed the trailing commas, not sure how I missed the prettier setup for that, and added the setting to the readme. |
@xt0rted, I also tried your |
@softprops thanks for merging this. Can you create a new tag & release version of your action so I can pin that in my GitHub workflow? |
@softprops & @xt0rted is something missing from the merged PR? I added this to my GitHub workflow:
Unfortunately, it created a release with empty release notes: https://github.com/bennycode/trading-signals/releases/tag/v2.5.0 With |
I'll publish this weekend |
ok. should be set here |
This is a bit old, but an excellent contribution. Any chance of adding an option to set the previous release? Currently, it generates to the last release created, which is a sensible default, but I'd like to differentiate between two cases:
I'm currently creating the body for the changelog manually, but I'd like to move to letting the action trigger github's automatic generation; this is the only thing missing for me. |
I'm not sure if anything else is needed to support this setting, but the change looks to match prior PRs. I used trailing commas in this update but I can remove those if you don't want them.
API Docs: https://docs.github.com/en/rest/reference/repos#create-a-release (
generate_release_notes
)Closes #167
Closes #173
Closes #176