Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: expose axios-retry options in error object #248

Merged
merged 1 commit into from
Nov 14, 2023
Merged

feat: expose axios-retry options in error object #248

merged 1 commit into from
Nov 14, 2023

Conversation

alexandre-abrioux
Copy link
Contributor

This PR aims to expose the plugin options inside error objects. This should close #166

@mindhells
Copy link
Member

@alexandre-abrioux, thanks a lot for your contribution, it looks great to me.

@yutak23 would you mind having a look?
You have been the most active and recent contributor so far, it would be great to have your feedback on this.

@yutak23
Copy link
Contributor

yutak23 commented Nov 13, 2023

@alexandre-abrioux, thanks a lot for your contribution, it looks great to me.

@yutak23 would you mind having a look? You have been the most active and recent contributor so far, it would be great to have your feedback on this.

I have taken a look at it. From what I see, I think the change here is fine.

@mindhells mindhells merged commit ed8f76d into softonic:master Nov 14, 2023
4 checks passed
@mindhells
Copy link
Member

Published as 3.8.2, thank you both!

@alexandre-abrioux alexandre-abrioux deleted the config-options branch November 14, 2023 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Access axios-retry configuration from the error object and fix its types
3 participants