Skip to content

Conversation

@fxdupont
Copy link
Contributor

@fxdupont fxdupont commented Jun 1, 2013

Misc changes:

  • compiler warnings
  • spelling errors
  • Encrypt and Decrypt Final reset operation type
  • a real bug (== in place of =)
  • CKA_SUB_PRIME_BITS -> CKA_SUBPRIME_BITS (please applications too?)
    (cf v2.30 of PKCS#11 standard from OASIS)

To come: HMAC, (completing) DSA, DH, ECDSA and (partial) ECDH.
BTW I tested it with OpenSSL 1.0.1e and Botan 1.10.3 (doesn't work with 1.11
because of c++11)

@rene-post rene-post merged commit 4e6e05b into softhsm:master Jun 10, 2013
saper added a commit to saper/SoftHSMv2 that referenced this pull request Jan 1, 2022
With C++ library assertions enabled, this crashes the p11test:

* thread softhsm#1, name = 'p11test', stop reason = signal SIGABRT
  * frame #0: 0x0000000800aa569a libc.so.7`__sys_thr_kill + 10
    frame softhsm#1: 0x0000000800aa3af4 libc.so.7`__raise + 52
    frame softhsm#2: 0x0000000800a19719 libc.so.7`abort + 73
    frame softhsm#3: 0x00000008007df9a2 libc++.so.1`std::__1::__libcpp_abort_debug_function(std::__1::__libcpp_debug_info const&) + 82
    frame softhsm#4: 0x00000000003beb6a p11test`std::__1::vector<unsigned char, SecureAllocator<unsigned char> >::operator[](unsigned long) + 122
    frame softhsm#5: 0x00000000003be096 p11test`ByteString::operator[](unsigned long) + 38
    frame softhsm#6: 0x00000000003412a6 p11test`SoftHSM::SymEncryptInit(unsigned long, _CK_MECHANISM*, unsigned long) + 3190
    frame softhsm#7: 0x000000000034267b p11test`SoftHSM::C_EncryptInit(unsigned long, _CK_MECHANISM*, unsigned long) + 75
    frame softhsm#8: 0x00000000003363b7 p11test`C_EncryptInit + 55
    frame softhsm#9: 0x0000000000283cfb p11test`SymmetricAlgorithmTests::encryptDecrypt(_CK_MECHANISM, unsigned long, unsigned long, unsigned long, unsigned long, bool) + 555
    frame softhsm#10: 0x000000000028c682 p11test`SymmetricAlgorithmTests::testAesEncryptDecrypt() + 3378
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants