Skip to content

Warn for specific thread module methods #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 29, 2022

Conversation

nanjekyejoannah
Copy link

@nanjekyejoannah nanjekyejoannah commented Nov 29, 2022

Dont merge until #13 and #14 are merged, some helper code cuts across.

This replaces #15

Threading module Notes

Python 2:

>>> from thread import get_ident
>>> from threading import get_ident
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
ImportError: cannot import name get_ident
>>> import threading
>>> from threading import _get_ident
>>>

Python 3:

>>> from threading import get_ident
>>> from thread import get_ident
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
ModuleNotFoundError: No module named 'thread'
>

Note:

There is no neutral way of porting

@nanjekyejoannah
Copy link
Author

bors try

bors bot added a commit that referenced this pull request Nov 29, 2022
@bors
Copy link

bors bot commented Nov 29, 2022

try

Build succeeded:

@ltratt
Copy link
Member

ltratt commented Nov 29, 2022

Excellent!

bors r+

@bors
Copy link

bors bot commented Nov 29, 2022

Build succeeded:

@bors bors bot merged commit b1a20bf into softdevteam:migration Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants