tracing: remove unused jaeger logic

Author: bmwill

Cargo.lock

@@ -24,7 +24,6 @@ serde_with = "2.1.0"
 serde_repr = "0.1"
 signature = "1.6.0"
 static_assertions = "1.1.0"
-opentelemetry = { version = "0.17.0", features = ["rt-tokio"] }
 zeroize = "1.5.7"
 schemars ="0.8.10"
 tap = "1.0.1"

crates/sui-types/Cargo.toml

@@ -8,15 +8,13 @@ use move_core_types::account_address::AccountAddress;
 use move_core_types::ident_str;
 use move_core_types::identifier::IdentStr;
 use move_core_types::language_storage::StructTag;
-use opentelemetry::{global, Context};
 use rand::Rng;
 use schemars::JsonSchema;
 use serde::{Deserialize, Serialize};
 use serde_with::serde_as;
 use serde_with::Bytes;
 use std::borrow::Borrow;
 use std::cmp::max;
-use std::collections::HashMap;
 use std::convert::{TryFrom, TryInto};
 use std::fmt;
 use std::str::FromStr;
@@ -488,19 +486,6 @@ impl AsRef<[u8]> for TransactionDigest {
     }
 }
 
-/// Returns a Context for OpenTelemetry tracing from a TransactionDigest
-// NOTE: See https://github.com/MystenLabs/sui/issues/852
-// The current code doesn't really work.  Maybe the traceparent needs to be a specific format,
-// prohably needs to be the propagated trace ID from the source.
-pub fn context_from_digest(digest: TransactionDigest) -> Context {
-    // TODO: don't create a HashMap, that wastes memory and costs an allocation!
-    let mut carrier = HashMap::new();
-    // TODO: figure out exactly what key to use.  I suspect it has to be the parent span ID in OpenTelemetry format.
-    carrier.insert("traceparent".to_string(), Hex::encode(digest.0));
-
-    global::get_text_map_propagator(|propagator| propagator.extract(&carrier))
-}
-
 impl Borrow<[u8]> for TransactionDigest {
     fn borrow(&self) -> &[u8] {
         &self.0

crates/sui-types/src/base_types.rs

@@ -12,21 +12,17 @@ publish = false
 console-subscriber = { version = "0.1.6", optional = true }
 crossterm = "0.25.0"
 once_cell = "1.13.0"
-opentelemetry = { version = "0.18.0", features = ["rt-tokio"], optional = true }
-opentelemetry-jaeger = { version = "0.17.0", features = ["rt-tokio"], optional = true }
 prometheus = "0.13.3"
 tokio = { workspace = true, features = ["sync", "macros", "rt", "rt-multi-thread"] }
 tracing = "0.1.37"
 tracing-appender = "0.2.2"
 tracing-bunyan-formatter = "0.3.3"
-tracing-opentelemetry = { version = "0.18.0", optional = true }
 tracing-subscriber = { version = "0.3.15", features = ["std", "time", "registry", "env-filter"] }
 workspace-hack = { version = "0.1", path = "../workspace-hack" }
 
 [features]
-default = ["jaeger"]
+default = []
 tokio-console = ["console-subscriber"]
-jaeger = ["tracing-opentelemetry", "opentelemetry", "opentelemetry-jaeger"]
 
 [dev-dependencies]
 camino = "1.0.9"