Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I want to use spaces to indent a code #2

Closed
ganmacs opened this issue Jul 1, 2019 · 7 comments
Closed

I want to use spaces to indent a code #2

ganmacs opened this issue Jul 1, 2019 · 7 comments

Comments

@ganmacs
Copy link

ganmacs commented Jul 1, 2019

Sorry if this issue is already discussed or duplicated one.

Ruby dev team no longer uses tabs* and ruby community uses space to indent code(e.g. rails, rubocop and fluentd ). I think it doesn't matter whether using spaces or tab, but I believe it's good to follow the community standard since it will be easy to understand for new contributors.
I'm happy if sockety project uses spaces to indent code. Are there any reasons to use tabs to ident?
@ioquatix

@ioquatix
Copy link
Member

ioquatix commented Jul 1, 2019

Yes, it's already discussed.

@ioquatix ioquatix closed this as completed Jul 1, 2019
@ganmacs
Copy link
Author

ganmacs commented Jul 1, 2019

Could you please tell me the link of discussion(or something else)? I'd like to know why this project uses spaces…

@ioquatix
Copy link
Member

ioquatix commented Jul 1, 2019

Let me summarise it so I can just link to it every time this discussion comes up.

@ioquatix
Copy link
Member

ioquatix commented Jul 1, 2019

This is my universal style guide, and I've linked through to RFC20 which explains the difference between tabs and spaces. https://github.com/ioquatix/universal-style-guide#indentation

If you've already invested in one way of doing indentation, its aways going to be a hard pill to swallow when someone does it differently. But look at it this way - diversity is good, even in code. Otherwise, we'd never make improvements.

@ganmacs
Copy link
Author

ganmacs commented Jul 1, 2019

Okay, I got your style. I'll follow this style in the project you organize (and I think that space or tab is a minor issue).
Thank you for your explanation. I'm glad to hear the reason 😄

@ganmacs
Copy link
Author

ganmacs commented Jul 3, 2019

thank you for interesting post.

BTW. can you review these PRs?
#1
socketry/protocol-http2#2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants