excecute multiple api calls on a rails controller

[michelson]

Hi there, I wanted to know if this code is correct?

  api_keys = Async do
    flow_client.api_keys(project_id: params[:flow_id])
    r.body
  end

  destinations = Async do
    r = flow_client.destinations(project_id: params[:flow_id])
    r.body
  end

  sources = Async do
    r = flow_client.sources(project_id: params[:flow_id])
    r.body
  end

  # are this waits blocking each other?
  @api_keys = api_keys.wait
  @destinations = destinations.wait
  @sources = sources.wait

[ioquatix]

I suggest the following changes:

1. Renamed r to response for clarity.
2. Added an ensure block to close the response to ensure there are no resource leakage.
3. Replaced response.body with response.read to retrieve the entire body of the response.

api_keys = Async do
  response = flow_client.api_keys(project_id: params[:flow_id])
  response.read
ensure
  response&.close
end

destinations = Async do
  response = flow_client.destinations(project_id: params[:flow_id])
  response.read
ensure
  response&.close
end

sources = Async do
  response = flow_client.sources(project_id: params[:flow_id])
  response.read
ensure
  response&.close
end

# Now, we wait for each asynchronous call to complete
@api_keys = api_keys.wait
@destinations = destinations.wait
@sources = sources.wait

This code executes three asynchronous API requests concurrently to fetch API keys, destinations, and sources for a given project ID (params[:flow_id]). It ensures that each response object is properly closed after reading its contents. Finally, it waits for each asynchronous call to complete and assigns the results to instance variables (@api_keys, @destinations, @sources).

Let me know if you need further clarification or help :)

[michelson]

Samuel, thank you very much for this detailed explanation. This library is fantastic. I've started using this in my code, and I'm seeing good results. Also, over the weekend, I deployed chaskiq.io with the Falcon server; it was a smooth process! awesome work 🙏

[ioquatix]

Awesome, I've updated the diagram - sorry I did the initial answer while I was out walking and it wasn't as clear as I wanted.

If you are interested in helping out, I'm working on an Async backed ActiveJob adapter: http://github.com/socketry/async-job - see the linked adapter for Rails/ActiveJob. Would be great to have some feedback on it!

[michelson]

Hi Samuel, I've saw that repo yesterday ⭐ , this is intended as a replacement for sidekiq or mission control? I could do some testings over the weekend :+1 is there any specific topic that you would expect on the feedback to be covered?

[ioquatix]

In theory you can replace sidekiq with it. However, it's still pretty fresh. Don't roll into production with it just yet :) But if you can try it out, that would be awesome! I suppose useful feedback would be "did it work" and whether you encountered any issues with the documentation or anything was unclear.

[michelson]

ok, I will spin a branch with it and see if it pass the tests suite :D