Skip to content

Commit

Permalink
[chore] Release 2.2.0
Browse files Browse the repository at this point in the history
  • Loading branch information
darrachequesne committed Nov 28, 2018
1 parent b00ae50 commit df05b73
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "socket.io",
"version": "2.1.1",
"version": "2.2.0",
"description": "node.js realtime framework server",
"keywords": [
"realtime",
Expand Down Expand Up @@ -28,7 +28,7 @@
"engine.io": "~3.3.1",
"has-binary2": "~1.0.2",
"socket.io-adapter": "~1.1.0",
"socket.io-client": "https://github.com/socketio/socket.io-client.git#develop",
"socket.io-client": "2.2.0",
"socket.io-parser": "~3.3.0"
},
"devDependencies": {
Expand Down

5 comments on commit df05b73

@davericher
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This breaks CORS via withCredentials defaulting to on

@darrachequesne
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@davericher I'll try to look into that. Could you please open an issue with all details? Thanks!

@sjones6
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@darrachequesne @davericher : Opened #3381. Still digging into the problem so details are thin. Will fill in as I debug more.

@Bramzor
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possible to roll this back as it breaks environments when the new update gets installed without knowing?

@darrachequesne
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when the new update gets installed without knowing

@Bramzor I don't understand, aren't you able to lock your dependencies?

Please sign in to comment.