Skip to content

Commit

Permalink
ci: ignore tests when publishing to npm (bis)
Browse files Browse the repository at this point in the history
`tags-ignore` seems to disable the workflow in all cases.
  • Loading branch information
darrachequesne committed Oct 9, 2024
1 parent 88efd44 commit a5d2368
Show file tree
Hide file tree
Showing 4 changed files with 14 additions and 15 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/ci-browser.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,13 @@ name: CI (browser)

on:
push:
branches:
- '**'
paths:
- 'packages/engine.io-parser/**'
- 'packages/engine.io-client/**'
- 'packages/socket.io-parser/**'
- 'packages/socket.io-client/**'
tags-ignore:
- '**@*'

permissions:
contents: read
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@ name: CI

on:
push:
tags-ignore:
- '**@*'
branches:
- '**'
pull_request:
schedule:
- cron: '0 0 * * 0'
Expand Down
19 changes: 9 additions & 10 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/engine.io/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
"@types/node": ">=10.0.0",
"accepts": "~1.3.4",
"base64id": "2.0.0",
"cookie": "~0.7.0",
"cookie": "~0.7.2",
"cors": "~2.8.5",
"debug": "~4.3.1",
"engine.io-parser": "~5.2.1",
Expand Down

0 comments on commit a5d2368

Please sign in to comment.