Fix parse error

We always need to send binary when encoding payloads when sending from
server to client, because the polling transport has to know the response
type ahead of time.

Author: Tony Kovanen

lib/index.js

@@ -3,7 +3,6 @@
  */
 
 var utf8 = require('utf8');
-var hasBinary = require('has-binary');
 var after = require('after');
 var keys = require('./keys');
 
@@ -227,7 +226,7 @@ exports.encodePayload = function (packets, supportsBinary, callback) {
     supportsBinary = null;
   }
 
-  if (supportsBinary && hasBinary(packets)) {
+  if (supportsBinary) {
     return exports.encodePayloadAsBinary(packets, callback);
   }
 

test/browser/index.js

@@ -9,3 +9,21 @@ if (Blob) {
 }
 
 require('./base64_object.js');
+
+// General browser only tests
+var parser = require('../../');
+var encode = parser.encodePacket;
+var decode = parser.decodePacket;
+var encPayload = parser.encodePayload;
+var decPayload = parser.decodePayload;
+
+describe('basic functionality', function () {
+  it('should encode string payloads as strings even if binary supported', function (done) {
+    encPayload([{ type: 'ping' }, { type: 'post' }], true, function(data) {
+      expect(data).to.be.a('string');
+      done();
+    });
+  });
+});
+
+

test/parser.js

@@ -153,15 +153,6 @@ module.exports = function(parser) {
         });
       });
 
-      describe('basic functionality', function () {
-        it('should encode string payloads as strings even if binary supported', function (done) {
-          encPayload([{ type: 'ping' }, { type: 'post' }], true, function(data) {
-            expect(data).to.be.a('string');
-            done();
-          });
-        });
-      });
-
       describe('encoding and decoding', function () {
         var seen = 0;
         it('should encode/decode packets', function (done) {