refactor: do not include the pid by default

So that the client knows whether the connection state recovery feature
is enabled.

See also: 54d5ee0

Author: darrachequesne

lib/socket.ts

@@ -275,7 +275,9 @@ export class Socket<
       } else {
         this.id = base64id.generateId(); // don't reuse the Engine.IO id because it's sensitive information
       }
-      this.pid = base64id.generateId();
+      if (this.server._opts.connectionStateRecovery) {
+        this.pid = base64id.generateId();
+      }
     }
     this.handshake = this.buildHandshake(auth);
   }

test/connection-state-recovery.ts

@@ -193,4 +193,26 @@ describe("connection state recovery", () => {
 
     io.close();
   });
+
+  it("should be disabled by default", async () => {
+    const httpServer = createServer().listen(0);
+    const io = new Server(httpServer);
+
+    // Engine.IO handshake
+    const sid = await eioHandshake(httpServer);
+
+    // Socket.IO handshake
+    await eioPush(httpServer, sid, "40");
+
+    const handshakeBody = await eioPoll(httpServer, sid);
+
+    expect(handshakeBody.startsWith("40")).to.be(true);
+
+    const handshake = JSON.parse(handshakeBody.substring(2));
+
+    expect(handshake.sid).to.not.be(undefined);
+    expect(handshake.pid).to.be(undefined);
+
+    io.close();
+  });
 });