Skip to content

Commit 5e56ec1

Browse files
refactor: properly extend the EventEmitter class
1 parent 7624147 commit 5e56ec1

File tree

4 files changed

+14
-6
lines changed

4 files changed

+14
-6
lines changed

packages/engine.io/lib/server.ts

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,11 @@ const ERROR_MESSAGES = new Map<ERROR_CODES, string>([
9595
[ERROR_CODES.UNSUPPORTED_PROTOCOL_VERSION, "Unsupported protocol version"],
9696
]);
9797

98-
export class Server extends EventEmitter<never, never, ServerReservedEvents> {
98+
export class Server extends EventEmitter<
99+
Record<never, never>,
100+
Record<never, never>,
101+
ServerReservedEvents
102+
> {
99103
public readonly opts: ServerOptions;
100104

101105
private clients: Map<string, Socket> = new Map();

packages/engine.io/lib/socket.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,8 @@ interface SocketEvents {
3131
const FAST_UPGRADE_INTERVAL_MS = 100;
3232

3333
export class Socket extends EventEmitter<
34-
never,
35-
never,
34+
Record<never, never>,
35+
Record<never, never>,
3636
SocketEvents
3737
> {
3838
public readonly id: string;

packages/engine.io/lib/transport.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,8 @@ interface TransportEvents {
1313
type ReadyState = "open" | "closing" | "closed";
1414

1515
export abstract class Transport extends EventEmitter<
16-
never,
17-
never,
16+
Record<never, never>,
17+
Record<never, never>,
1818
TransportEvents
1919
> {
2020
public writable = false;

packages/socket.io/lib/adapter.ts

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,11 @@ interface AdapterEvents {
3131
"error": (err: Error) => void;
3232
}
3333

34-
export class InMemoryAdapter extends EventEmitter<never, never, AdapterEvents> {
34+
export class InMemoryAdapter extends EventEmitter<
35+
Record<never, never>,
36+
Record<never, never>,
37+
AdapterEvents
38+
> {
3539
protected readonly nsp: Namespace;
3640

3741
protected rooms: Map<Room, Set<SocketId>> = new Map();

0 commit comments

Comments
 (0)