fix: do not swallow user exceptions

Following [1], any exception in a user-provided event listener would
get caught in the try...catch of the decoder and result in the
reconnection of the socket.

[1]: c597023

Related:

- #1551
- #1554
- #1557

Author: darrachequesne

lib/manager.ts

@@ -2,6 +2,7 @@ import {
   Socket as Engine,
   SocketOptions as EngineOptions,
   installTimerFunctions,
+  nextTick,
 } from "engine.io-client";
 import { Socket, SocketOptions, DisconnectDescription } from "./socket.js";
 import * as parser from "socket.io-parser";
@@ -427,7 +428,7 @@ export class Manager<
     try {
       this.decoder.add(data);
     } catch (e) {
-      this.onclose("parse error");
+      this.onclose("parse error", e as Error);
     }
   }
 
@@ -437,7 +438,10 @@ export class Manager<
    * @private
    */
   private ondecoded(packet): void {
-    this.emitReserved("packet", packet);
+    // the nextTick call prevents an exception in a user-provided event listener from triggering a disconnection due to a "parse error"
+    nextTick(() => {
+      this.emitReserved("packet", packet);
+    }, this.setTimeoutFn);
   }
 
   /**

lib/socket.ts

@@ -725,5 +725,6 @@ export namespace Socket {
     | "io client disconnect"
     | "ping timeout"
     | "transport close"
-    | "transport error";
+    | "transport error"
+    | "parse error";
 }

package-lock.json

@@ -34,7 +34,7 @@
   "dependencies": {
     "@socket.io/component-emitter": "~3.1.0",
     "debug": "~4.3.2",
-    "engine.io-client": "~6.2.1",
+    "engine.io-client": "~6.2.3",
     "socket.io-parser": "~4.2.0"
   },
   "devDependencies": {