File tree Expand file tree Collapse file tree 2 files changed +3
-0
lines changed Expand file tree Collapse file tree 2 files changed +3
-0
lines changed Original file line number Diff line number Diff line change @@ -10,6 +10,7 @@ const debug = debugModule("engine:socket");
1010
1111export class Socket extends EventEmitter {
1212 public readonly protocol : number ;
13+ // TODO for the next major release: do not keep the reference to the first HTTP request, as it stays in memory
1314 public readonly request : IncomingMessage ;
1415 public readonly remoteAddress : string ;
1516
Original file line number Diff line number Diff line change @@ -75,6 +75,7 @@ export class Polling extends Transport {
7575 debug ( "request overlap" ) ;
7676 // assert: this.res, '.req and .res should be (un)set together'
7777 this . onError ( "overlap from client" ) ;
78+ // TODO for the next major release: use an HTTP 400 status code (https://github.com/socketio/engine.io/issues/650)
7879 res . writeHead ( 500 ) ;
7980 res . end ( ) ;
8081 return ;
@@ -116,6 +117,7 @@ export class Polling extends Transport {
116117 if ( this . dataReq ) {
117118 // assert: this.dataRes, '.dataReq and .dataRes should be (un)set together'
118119 this . onError ( "data request overlap from client" ) ;
120+ // TODO for the next major release: use an HTTP 400 status code (https://github.com/socketio/engine.io/issues/650)
119121 res . writeHead ( 500 ) ;
120122 res . end ( ) ;
121123 return ;
You can’t perform that action at this time.
0 commit comments