add tupleCursor and type dictCursor #2086
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
Polandia94
force-pushed
the
SNOW-1763594-add-TupleCursor-and-type-DictCursor
branch
from
71c57e4
to
7f9d76b
Compare
|
recheck |
|
I have read the CLA Document and I hereby sign the CLA |
| def fetchall(self) -> list[dict]: | ||
| return super().fetchall() | ||
|
|
||
| class TupleCursor(SnowflakeCursor): |
There was a problem hiding this comment.
do we need TupleCursor? this is effectively the default SnowflakeCursor.
There was a problem hiding this comment.
SnowflakeCursor has to return Union[None|dict|tuple] because could be instanciated as
SnowflakeCursor(use_dict_result=True).
TupleCursor is just a SnowflakeCursor that return Union[None|tuple] on fetch
On DictCursor the better types will not require nothing for the user, on TupleCursor it will require that they start to instanciate as TupleDict, so maybe its not useful. I let you to decide, let me know if you want and i delete the TupleCursor from PR and issue.
Add tupleCursor like dictCursor but always return Tuple. Modify types of dictCursor to always return dict
related to: #2085