-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SNOW-1671768] Ignore max retries error when getting acelerate config #1212
[SNOW-1671768] Ignore max retries error when getting acelerate config #1212
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My general preference is that: we only enable bucket acceleration configuration is we are able to get bucket configuration and bucket configuration indeed returns that acceleration is enabled for the bucket, in all other scenarios, whatever error returned by http, we just fallback to treating that bucket acceleration is not enabled. This is a much robust way. And this is how python connector handler the error as well. Check the code here https://github.com/snowflakedb/snowflake-connector-python/blob/3c8255935b9aebc2edee8de3913959f86596739f/src/snowflake/connector/s3_storage_client.py#L583
@sfc-gh-hyu Ok, changed to ignore all errors in that part of the code, logging them all at warn level. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1212 +/- ##
==========================================
+ Coverage 82.46% 82.60% +0.13%
==========================================
Files 54 54
Lines 12916 12909 -7
==========================================
+ Hits 10651 10663 +12
+ Misses 2265 2246 -19
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Ignore and log all errors thrown while getting accelerate configuration from bucket.
Checklist