Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SNOW-1671768] Ignore max retries error when getting acelerate config #1212

Merged
merged 4 commits into from
Sep 27, 2024

Conversation

sfc-gh-astachowski
Copy link
Contributor

@sfc-gh-astachowski sfc-gh-astachowski commented Sep 20, 2024

Description

Ignore and log all errors thrown while getting accelerate configuration from bucket.

Checklist

  • Created tests which fail without the change (if possible)
  • Extended the README / documentation, if necessary

@sfc-gh-astachowski sfc-gh-astachowski requested a review from a team as a code owner September 20, 2024 09:40
Copy link

@sfc-gh-hyu sfc-gh-hyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My general preference is that: we only enable bucket acceleration configuration is we are able to get bucket configuration and bucket configuration indeed returns that acceleration is enabled for the bucket, in all other scenarios, whatever error returned by http, we just fallback to treating that bucket acceleration is not enabled. This is a much robust way. And this is how python connector handler the error as well. Check the code here https://github.com/snowflakedb/snowflake-connector-python/blob/3c8255935b9aebc2edee8de3913959f86596739f/src/snowflake/connector/s3_storage_client.py#L583

@sfc-gh-astachowski
Copy link
Contributor Author

@sfc-gh-hyu Ok, changed to ignore all errors in that part of the code, logging them all at warn level.

Copy link

codecov bot commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.60%. Comparing base (3428b00) to head (796700d).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1212      +/-   ##
==========================================
+ Coverage   82.46%   82.60%   +0.13%     
==========================================
  Files          54       54              
  Lines       12916    12909       -7     
==========================================
+ Hits        10651    10663      +12     
+ Misses       2265     2246      -19     
Flag Coverage Δ
82.60% <100.00%> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@sfc-gh-pmotacki sfc-gh-pmotacki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

file_transfer_agent.go Show resolved Hide resolved
@sfc-gh-pmotacki sfc-gh-pmotacki merged commit a26ac8a into master Sep 27, 2024
37 checks passed
@sfc-gh-pmotacki sfc-gh-pmotacki deleted the SNOW-1671768-ignore-max-retries-error branch September 27, 2024 08:55
@github-actions github-actions bot locked and limited conversation to collaborators Sep 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants