Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected route name for delete action on filestable on assets #15819

Merged
merged 2 commits into from
Nov 14, 2024

Conversation

snipe
Copy link
Owner

@snipe snipe commented Nov 14, 2024

This fixes a bug when trying to delete an uploaded asset file where it would say that the asset does not exist and the file would not be deleted.

Signed-off-by: snipe <snipe@snipe.net>
Copy link

what-the-diff bot commented Nov 14, 2024

PR Summary

  • Improved URL Routing for File Deletions Across Tables
    The route for deleting files in the asset table has been adjusted. It used to be delete/modelfile but has now been changed to delete/assetfile. This change aligns the terminology used in the URL with the actual contents of the table, making the system more intuitive and user-friendly.

  • Adjusted URL Route for Model File Deletions
    In a similar vein, the route for deleting files in the model table has been changed. Instead of the older userfile.destroy, it now uses modelfile.destroy. This more accurately reflects the operations being performed, thereby enhancing consistency and improving the logic of the URL structure.

Signed-off-by: snipe <snipe@snipe.net>
@snipe snipe merged commit 7b7a848 into develop Nov 14, 2024
8 checks passed
@snipe snipe deleted the fixes_asset_file_deletion branch November 14, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant