-
-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implements first pass at csv exports of reports #109
Conversation
Definitely need this in a reports controller at some point - we'll also have more reports than just depreciation, so what we have was just to get something out there, check the depreciation math, etc. I don't think we need pagination in a csv export, do we? I would expect a full dump on csv export. And hey - thanks so much for working on this - I'm stoked we get to work on something together! |
Implements first pass at csv exports of reports
No problem. I am excited too! |
References #35 (possibly fixes for now?)
This is a rough first pass at CSV exports for reports. The merge includes
There may be a good argument to create a separate Reports controller to manage the reporting routes and export functionality. Seems a little dirty to stuff it in the assets controller. This merge does not account for paging.
I should probably add some tests to this thing too.