Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implements first pass at csv exports of reports #109

Merged
merged 3 commits into from
Dec 2, 2013

Conversation

desmondmorris
Copy link

References #35 (possibly fixes for now?)
This is a rough first pass at CSV exports for reports. The merge includes

  • A new route "/reports/export"
  • A new method in the AssetController ("exportReports"). This method borrows functionality from the getReports method and spits out the list of assets in csv format ("report.csv")

There may be a good argument to create a separate Reports controller to manage the reporting routes and export functionality. Seems a little dirty to stuff it in the assets controller. This merge does not account for paging.

I should probably add some tests to this thing too.

@snipe
Copy link
Owner

snipe commented Dec 2, 2013

Definitely need this in a reports controller at some point - we'll also have more reports than just depreciation, so what we have was just to get something out there, check the depreciation math, etc.

I don't think we need pagination in a csv export, do we? I would expect a full dump on csv export.

And hey - thanks so much for working on this - I'm stoked we get to work on something together!

snipe added a commit that referenced this pull request Dec 2, 2013
Implements first pass at csv exports of reports
@snipe snipe merged commit dddba11 into snipe:develop Dec 2, 2013
@desmondmorris
Copy link
Author

No problem. I am excited too!

snipe added a commit that referenced this pull request May 6, 2014
@stevecookms stevecookms mentioned this pull request Jul 19, 2016
@rmgau rmgau mentioned this pull request Aug 5, 2016
@dooley1023 dooley1023 mentioned this pull request Feb 2, 2017
2 tasks
@katecruser katecruser mentioned this pull request Feb 8, 2017
2 tasks
@Mike1704 Mike1704 mentioned this pull request Mar 3, 2017
@ESWBitto ESWBitto mentioned this pull request Mar 16, 2017
2 tasks
@aaronlott aaronlott mentioned this pull request Jun 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants