Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table columns from history and assets tab conflicts #7834

Closed
Scorcher opened this issue Feb 19, 2020 · 3 comments
Closed

Table columns from history and assets tab conflicts #7834

Scorcher opened this issue Feb 19, 2020 · 3 comments
Labels

Comments

@Scorcher
Copy link
Contributor

Please confirm you have done the following before posting your bug report:

Describe the bug
After changing column set on assets tab of any hardware we have no columns on history page.

To Reproduce
Steps to reproduce the behavior:

  1. Go to any hardware detail page on assets tab (/hardware/XXX#assets)
  2. Choose you personal set of columns
  3. Go to history tab (/hardware/XXX#history)
  4. There you can see that API return some rows, but did not show it
  5. Choose you personal set of columns on this tab
  6. Go to history tab (/hardware/XXX#history) and go to step 4

Expected behavior
I want to have separate column set for each table on each page and it should be in memory (cookie or something else)

Server (please complete the following information):

  • Snipe-IT Version 4.8.0
  • OS: Ubuntu 16.04 LTS
  • Web Server: Apache/2.4.18 (Ubuntu)
  • PHP Version PHP 7.1.33-2+ubuntu16.04.1+deb.sury.org+1

Desktop (please complete the following information):

  • OS: MacOS 10.15.2
  • Browser: Chrome
  • Version: 80.0.3987.100 (Official Build) (64-bit)

Error Messages

  • no error message

This problem was explained here #6038
And probably here #4784

@Scorcher
Copy link
Contributor Author

Seems like this option

cookieIdTable: '{{ Route::currentRouteName() }}',

overrides per-table "data-" attributes.

I have investigaed codebase and found that each table has personal attribute "data-cookie-id-table". So i think that we can remove line "cookieIdTable: '{{ Route::currentRouteName() }}',".

@stale
Copy link

stale bot commented Apr 19, 2020

Is this still relevant? We haven't heard from anyone in a bit. If so, please comment with any updates or additional detail.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Don't take it personally, we just need to keep a handle on things. Thank you for your contributions!

@stale stale bot added the stale label Apr 19, 2020
@stale
Copy link

stale bot commented Apr 26, 2020

This issue has been automatically closed because it has not had recent activity. If you believe this is still an issue, please confirm that this issue is still happening in the most recent version of Snipe-IT and reply to this thread to re-open it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant