"Whoops, looks like something went wrong" message with checkin and checkout

[HafeleNZ]

Please confirm you have done the following before posting your bug report:

• I have enabled debug mode
• I have read checked the Common Issues page

Describe the bug
A clear and concise description of what the bug is.

When trying to check in or check out an asset a “Whoops, looks like something went wrong.” Message is displayed
This error is displayed when using the action button when you have an asset selected or when selecting checkin or checkout from the All Asset screen or any other screen that allows multiple assets selected.

To Reproduce
Steps to reproduce the behavior:

1. Go to 'Any asset'
2. Click on 'Actions'
3. Click on ‘Checkin Asset or Checkout Asset’
4. See error

Expected behavior

For the checkin or checkout options page to be displayed. So an Asset can be assigned or removed from a user.

Screenshots
If applicable, add screenshots to help explain your problem.

When using:

Result:

Server (please complete the following information):

• Snipe-IT Version V4.6.15 - Build 4011
• OS: [e.g. Ubuntu, CentOS] CentOS Linux 7
• Web Server: [e.g. Apache, IIS] Apache/2.4.6
• PHP Version 5.6.40

Desktop (please complete the following information):

• OS: [e.g. iOS] Windows 10 pro
• Browser [e.g. chrome, safari] Microsoft Edge
• Version [e.g. 22] 42.17134.1.0

Error Messages

HTML1300: Navigation occurred.
checkin (1,1)

HTTP500: SERVER ERROR - The server encountered an unexpected condition that prevented it from fulfilling the request.

Additional context

• Is this a fresh install or an upgrade? An upgrade. Was working before upgrade.

• What OS and web server you're running Snipe-IT on

• What method you used to install Snipe-IT (install.sh, manual installation, docker, etc)

• Include what you've done so far in the installation, and if you got any error messages along the way.

• Indicate whether or not you've manually edited any data directly in the database

Add any other context about the problem here.

Please do not post an issue without answering the related questions above. If you have opened a different issue and already answered these questions, answer them again, once for every ticket. It will be next to impossible for us to help you.

[snipe]

Please provide the relevant info from your app errors logs.

[ZhisongZhang]

I am currently playing with version 4.7.3. it works if the asset check out from a user, however, it the asset has been checkout to a location and check back in, it get "Whoops, looks like something went wrong." problem.
I believe because the user variable is not defined from what I can see

.

[gilesytheking]

I have a similar issue, however it only seems to happen when checking in an asset that has been assigned to another asset or location. Checkout function works fine.

[ZhisongZhang]

I have rolled back to 4.6.18 seems like this only happen to 4.7 above

[snipe]

That doesn't really make sense for 4.7.3 though, as we're checking whether the user exists or not on that line....

 if (($user) && ($backto =='user')) {

[ZhisongZhang]

$user==null when the asset is checkout to location?

if (($user) || ($user=null) && ($backto =='user')) {

will this help?

[snipe]

No, the $user variable wouldn't even be set if it's checked out to anything other than a user:

if ($asset->assignedType() == Asset::USER) {
     $user = $asset->assignedTo;
}

Plus the error is that the variable is undefined. A variable that is set but set to null is still defined.

[ZhisongZhang]

It would be easier to have a look at what has been changed since 4.6.18. It works in that version.

[snipe]

So, compare it. v4.6.8...v4.7.3

There were neatly 300 files touched in that upgrade. The history on the AssetCheckin file is much shorter:

https://github.com/snipe/snipe-it/commits/master/app/Http/Controllers/AssetCheckinController.php

But the underlying framework changed, and so did the minimum required version of PHP, so....

[ZhisongZhang]

4.6.18 - if ($backto=='user') {
4.7.3 - if (($user) && ($backto =='user')) {
$user is not define when checked out to asset or location

you have not defined the $user until line 56 and it is inside the if condition. I would suggest you to declare $user in line 54?

[snipe]

Try changing that to :

if ((isset($user)) && ($backto =='user')) {

and see if that helps.

[ZhisongZhang]

yup, it works like magic. thanks for your help.

[HafeleNZ]

Hello,

Can we please reopen this as we have not replied to the ordinal request from Snipe asking for the App error logs.

Please see logs below:

Log details:

(1/1) BadMethodCallException Method [getCheckin] does not exist.

in Controller.php line 82
at Controller->__call('getCheckin', array('912'))
at AssetsController->getCheckin('912')
at call_user_func_array(array(object(AssetsController), 'getCheckin'), array('assetId' => '912'))in Controller.php line 55
at Controller->callAction('getCheckin', array('assetId' => '912'))in ControllerDispatcher.php line 44
at ControllerDispatcher->dispatch(object(Route), object(AssetsController), 'getCheckin')in Route.php line 204
at Route->runController()in Route.php line 160
at Route->run()in Router.php line 572
at Router->Illuminate\Routing{closure}(object(Request))in Pipeline.php line 30
at Pipeline->Illuminate\Routing{closure}(object(Request))in Authenticate.php line 43
at Authenticate->handle(object(Request), object(Closure))in Pipeline.php line 148
at Pipeline->Illuminate\Pipeline{closure}(object(Request))in Pipeline.php line 53
at Pipeline->Illuminate\Routing{closure}(object(Request))in CreateFreshApiToken.php line 49
at CreateFreshApiToken->handle(object(Request), object(Closure))in Pipeline.php line 148
at Pipeline->Illuminate\Pipeline{closure}(object(Request))in Pipeline.php line 53
at Pipeline->Illuminate\Routing{closure}(object(Request))in CheckForTwoFactor.php line 49
at CheckForTwoFactor->handle(object(Request), object(Closure))in Pipeline.php line 148
at Pipeline->Illuminate\Pipeline{closure}(object(Request))in Pipeline.php line 53
at Pipeline->Illuminate\Routing{closure}(object(Request))in CheckLocale.php line 42
at CheckLocale->handle(object(Request), object(Closure))in Pipeline.php line 148
at Pipeline->Illuminate\Pipeline{closure}(object(Request))in Pipeline.php line 53
at Pipeline->Illuminate\Routing{closure}(object(Request))in VerifyCsrfToken.php line 65
at VerifyCsrfToken->handle(object(Request), object(Closure))in Pipeline.php line 148
at Pipeline->Illuminate\Pipeline{closure}(object(Request))in Pipeline.php line 53
at Pipeline->Illuminate\Routing{closure}(object(Request))in AddQueuedCookiesToResponse.php line 37
at AddQueuedCookiesToResponse->handle(object(Request), object(Closure))in Pipeline.php line 148
at Pipeline->Illuminate\Pipeline{closure}(object(Request))in Pipeline.php line 53
at Pipeline->Illuminate\Routing{closure}(object(Request))in EncryptCookies.php line 59
at EncryptCookies->handle(object(Request), object(Closure))in Pipeline.php line 148
at Pipeline->Illuminate\Pipeline{closure}(object(Request))in Pipeline.php line 53
at Pipeline->Illuminate\Routing{closure}(object(Request))in Pipeline.php line 102
at Pipeline->then(object(Closure))in Router.php line 574
at Router->runRouteWithinStack(object(Route), object(Request))in Router.php line 533
at Router->dispatchToRoute(object(Request))in Router.php line 511
at Router->dispatch(object(Request))in Kernel.php line 176
at Kernel->Illuminate\Foundation\Http{closure}(object(Request))in Pipeline.php line 30
at Pipeline->Illuminate\Routing{closure}(object(Request))in Debugbar.php line 51
at Debugbar->handle(object(Request), object(Closure))in Pipeline.php line 148
at Pipeline->Illuminate\Pipeline{closure}(object(Request))in Pipeline.php line 53
at Pipeline->Illuminate\Routing{closure}(object(Request))in TransformsRequest.php line 30
at TransformsRequest->handle(object(Request), object(Closure))in Pipeline.php line 148
at Pipeline->Illuminate\Pipeline{closure}(object(Request))in Pipeline.php line 53
at Pipeline->Illuminate\Routing{closure}(object(Request))in CheckForDebug.php line 25
at CheckForDebug->handle(object(Request), object(Closure))in Pipeline.php line 148
at Pipeline->Illuminate\Pipeline{closure}(object(Request))in Pipeline.php line 53
at Pipeline->Illuminate\Routing{closure}(object(Request))in CheckForSetup.php line 27
at CheckForSetup->handle(object(Request), object(Closure))in Pipeline.php line 148
at Pipeline->Illuminate\Pipeline{closure}(object(Request))in Pipeline.php line 53
at Pipeline->Illuminate\Routing{closure}(object(Request))in TrustProxies.php line 56
at TrustProxies->handle(object(Request), object(Closure))in Pipeline.php line 148
at Pipeline->Illuminate\Pipeline{closure}(object(Request))in Pipeline.php line 53
at Pipeline->Illuminate\Routing{closure}(object(Request))in NosniffGuard.php line 17
at NosniffGuard->handle(object(Request), object(Closure))in Pipeline.php line 148
at Pipeline->Illuminate\Pipeline{closure}(object(Request))in Pipeline.php line 53
at Pipeline->Illuminate\Routing{closure}(object(Request))in ContentSecurityPolicyHeader.php line 18
at ContentSecurityPolicyHeader->handle(object(Request), object(Closure))in Pipeline.php line 148
at Pipeline->Illuminate\Pipeline{closure}(object(Request))in Pipeline.php line 53
at Pipeline->Illuminate\Routing{closure}(object(Request))in ReferrerPolicyHeader.php line 17
at ReferrerPolicyHeader->handle(object(Request), object(Closure))in Pipeline.php line 148
at Pipeline->Illuminate\Pipeline{closure}(object(Request))in Pipeline.php line 53
at Pipeline->Illuminate\Routing{closure}(object(Request))in XssProtectHeader.php line 18
at XssProtectHeader->handle(object(Request), object(Closure))in Pipeline.php line 148
at Pipeline->Illuminate\Pipeline{closure}(object(Request))in Pipeline.php line 53
at Pipeline->Illuminate\Routing{closure}(object(Request))in FrameGuard.php line 17
at FrameGuard->handle(object(Request), object(Closure))in Pipeline.php line 148
at Pipeline->Illuminate\Pipeline{closure}(object(Request))in Pipeline.php line 53
at Pipeline->Illuminate\Routing{closure}(object(Request))in ShareErrorsFromSession.php line 49
at ShareErrorsFromSession->handle(object(Request), object(Closure))in Pipeline.php line 148
at Pipeline->Illuminate\Pipeline{closure}(object(Request))in Pipeline.php line 53
at Pipeline->Illuminate\Routing{closure}(object(Request))in StartSession.php line 64
at StartSession->handle(object(Request), object(Closure))in Pipeline.php line 148
at Pipeline->Illuminate\Pipeline{closure}(object(Request))in Pipeline.php line 53
at Pipeline->Illuminate\Routing{closure}(object(Request))in CheckForMaintenanceMode.php line 46
at CheckForMaintenanceMode->handle(object(Request), object(Closure))in Pipeline.php line 148
at Pipeline->Illuminate\Pipeline{closure}(object(Request))in Pipeline.php line 53
at Pipeline->Illuminate\Routing{closure}(object(Request))in Pipeline.php line 102
at Pipeline->then(object(Closure))in Kernel.php line 151
at Kernel->sendRequestThroughRouter(object(Request))in Kernel.php line 116
at Kernel->handle(object(Request))in index.php line 59

[snipe]

That's a different error than the ones people were reporting earlier in the thread. My guess would be you have some old cached views or files, as the checkin methods were moved to AssetCheckinController.php several versions ago. You can try running the cache clearing commands listed here: https://snipe-it.readme.io/docs/common-issues#section-quick-tip-handy-commands

Common Issues

These commands should be run from your Snipe-IT project root, just like every other cli command we mention. They should not need to be run as root/sudo/admin. These commands clear out cached service files that help speed up modern PHP applications but can also very occasionally be out of date,...

[HafeleNZ]

Yes that did the trick. Thank you for the quick response!