Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API: PATCH /hardware/:id - setting requestable field has no effect #6921

Closed
2 tasks done
sw-mreyes opened this issue Apr 17, 2019 · 4 comments
Closed
2 tasks done

API: PATCH /hardware/:id - setting requestable field has no effect #6921

sw-mreyes opened this issue Apr 17, 2019 · 4 comments
Labels

Comments

@sw-mreyes
Copy link
Contributor

sw-mreyes commented Apr 17, 2019

Please confirm you have done the following before posting your bug report:

Describe the bug
Setting the 'requestable' flag for an asset via PATCH to the /hardware/:id endpoint has no effect.

To Reproduce
Send a PATCH request with requestable=true to the /hardware/:id endpoint, supplying a valid ID of an asset that has the requestable flag not set.

I've also tried requestable=True, requestable=1, both yield the same result.

Expected behavior
The asset should have the requestable flag set.

Server (please complete the following information):

  • Snipe-IT Version v4.6.15 build 4011 (gd1e9fbfa2)
  • OS: Ubuntu
  • Web Server: NGINX
  • PHP Version 7.0.33-0+deb9u3

Error Messages
None, the request ist successfull {'status': 'success', 'payload': {...}, 'messages': 'Asset updated successfully.'}

@stale
Copy link

stale bot commented Jun 16, 2019

Is this still relevant? We haven't heard from anyone in a bit. If so, please comment with any updates or additional detail.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Don't take it personally, we just need to keep a handle on things. Thank you for your contributions!

@stale stale bot added the stale label Jun 16, 2019
@stale
Copy link

stale bot commented Jun 23, 2019

This issue has been automatically closed because it has not had recent activity. If you believe this is still an issue, please confirm that this issue is still happening in the most recent version of Snipe-IT and reply to this thread to re-open it.

@stale stale bot closed this as completed Jun 23, 2019
@stale
Copy link

stale bot commented Jun 23, 2019

This issue has been automatically closed because it has not had recent activity. If you believe this is still an issue, please confirm that this issue is still happening in the most recent version of Snipe-IT and reply to this thread to re-open it.

@bigtreeEdo
Copy link
Contributor

bigtreeEdo commented Feb 4, 2020

I came into same issue.
fillable fields defined in app/models/Asset.php missing 'requestable'.

protected $fillable = [
        'asset_tag',
        'assigned_to',
        'assigned_type',
        'company_id',
        'image',
        'location_id',
        'model_id',
        'name',
        'notes',
        'order_number',
        'purchase_cost',
        'purchase_date',
        'rtd_location_id',
        'serial',
        'status_id',
        'supplier_id',
        'warranty_months',
    ];

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants