Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dashes ( "-" ) not permitted in fields which state that they are #123

Closed
DGAzr opened this issue Feb 11, 2014 · 2 comments
Closed

Dashes ( "-" ) not permitted in fields which state that they are #123

DGAzr opened this issue Feb 11, 2014 · 2 comments

Comments

@DGAzr
Copy link

DGAzr commented Feb 11, 2014

I think the problem is right here: https://github.com/snipe/snipe-it/blob/develop/app/validators.php#L5

Just need to escape the dash so it's not being interpreted as a range. I started to do a proper pull request, but I realized I'm bad at GitHub :)

screen shot 2014-02-10 at 21 47 54
@snipe
Copy link
Owner

snipe commented Feb 11, 2014

Haha - well, if you'd like to get better, I can walk you through the pull request. Otherwise I can fix it :)

@DGAzr
Copy link
Author

DGAzr commented Feb 11, 2014

Tried it again this morning with more sleep, let me know if that's the correct way! Thanks for your patience!

@snipe snipe closed this as completed May 6, 2014
@stevecookms stevecookms mentioned this issue Jul 19, 2016
Closed
@eantong eantong mentioned this issue Sep 12, 2016
Closed
@Lakshman2309 Lakshman2309 mentioned this issue Dec 23, 2016
Closed
@xxtheatrainxx xxtheatrainxx mentioned this issue Dec 28, 2016
Closed
@MoazzamMuhammadKhan MoazzamMuhammadKhan mentioned this issue Jan 1, 2017
Closed
@dooley1023 dooley1023 mentioned this issue Feb 2, 2017
Closed
2 tasks
@katecruser katecruser mentioned this issue Feb 8, 2017
Closed
2 tasks
@Mike1704 Mike1704 mentioned this issue Mar 3, 2017
Closed
@srirdz srirdz mentioned this issue Mar 20, 2017
Closed
@shindelhu shindelhu mentioned this issue Mar 31, 2017
Closed
@aaronlott aaronlott mentioned this issue Jun 13, 2017
Closed
@hairysamurai hairysamurai mentioned this issue Sep 12, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@snipe @DGAzr