From 69f71e1170ced7897d5287ea3fbc9627e4b63c7f Mon Sep 17 00:00:00 2001 From: Marin Atanasov <8436925+tyxla@users.noreply.github.com> Date: Thu, 7 Nov 2024 18:14:20 +0900 Subject: [PATCH] Data: Rename useSelect internals to fix React Compiler violations (#66807) Co-authored-by: tyxla Co-authored-by: Mamaduka --- packages/data/src/components/use-select/index.js | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/packages/data/src/components/use-select/index.js b/packages/data/src/components/use-select/index.js index 3e28e9489e977e..15a3c88d2d5543 100644 --- a/packages/data/src/components/use-select/index.js +++ b/packages/data/src/components/use-select/index.js @@ -209,11 +209,11 @@ function Store( registry, suspense ) { }; } -function useStaticSelect( storeName ) { +function _useStaticSelect( storeName ) { return useRegistry().select( storeName ); } -function useMappingSelect( suspense, mapSelect, deps ) { +function _useMappingSelect( suspense, mapSelect, deps ) { const registry = useRegistry(); const isAsync = useAsyncMode(); const store = useMemo( @@ -308,13 +308,11 @@ export default function useSelect( mapSelect, deps ) { ); } - /* eslint-disable react-hooks/rules-of-hooks */ // `staticSelectMode` is not allowed to change during the hook instance's, // lifetime, so the rules of hooks are not really violated. return staticSelectMode - ? useStaticSelect( mapSelect ) - : useMappingSelect( false, mapSelect, deps ); - /* eslint-enable react-hooks/rules-of-hooks */ + ? _useStaticSelect( mapSelect ) + : _useMappingSelect( false, mapSelect, deps ); } /** @@ -337,5 +335,5 @@ export default function useSelect( mapSelect, deps ) { * @return {ReturnType} Data object returned by the `mapSelect` function. */ export function useSuspenseSelect( mapSelect, deps ) { - return useMappingSelect( true, mapSelect, deps ); + return _useMappingSelect( true, mapSelect, deps ); }