Skip to content

Commit cf31a19

Browse files
committed
Squashed commit of the following:
commit e3f8a33 Author: Joseph Luck <josephreubenluck@gmail.com> Date: Fri Mar 24 12:42:09 2023 +0000 (ISSUELESS) Support editing existing comment if one exists commit bea17d7 Author: Arnaud Benhamdine <arnaud.benhamdine@gmail.com> Date: Wed Apr 26 15:04:49 2023 +0200 Package commit 8a05d00 Author: Arnaud Benhamdine <arnaud.benhamdine@gmail.com> Date: Wed Apr 26 15:00:18 2023 +0200 Fix some lint false positives commit cdf2a70 Author: Arnaud Benhamdine <arnaud.benhamdine@gmail.com> Date: Wed Apr 26 15:00:01 2023 +0200 Update some dependencies, fix security error commit 716dcc8 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Wed Apr 26 14:41:46 2023 +0200 Bump jest-circus from 29.3.1 to 29.5.0 (#476) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 8781ec6 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Wed Apr 26 14:41:37 2023 +0200 Bump @types/node from 18.11.18 to 18.16.1 (#490) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit d0f63bd Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Wed Apr 26 14:41:27 2023 +0200 Bump @typescript-eslint/parser from 5.48.0 to 5.59.1 (#487) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 2b11cbd Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Mar 27 15:28:23 2023 +0200 Bump ts-jest from 29.0.3 to 29.0.5 (#455) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit afca8f4 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Mar 27 11:06:52 2023 +0200 Bump jest and @types/jest (#472) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 3c5ce5d Author: Bharathvaj <16360498+bharathvaj-ganesan@users.noreply.github.com> Date: Mon Mar 27 14:36:38 2023 +0530 Update usage example in README.md (#463) commit 400280a Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Mar 27 11:02:16 2023 +0200 Bump @octokit/rest from 19.0.5 to 19.0.7 (#458) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit d184cc3 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Mar 27 11:01:57 2023 +0200 Bump @typescript-eslint/eslint-plugin from 5.44.0 to 5.56.0 (#470) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 86d9a0b Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Mar 27 11:01:48 2023 +0200 Bump typescript from 4.9.3 to 5.0.2 (#469) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 9fa627e Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Sun Jan 22 10:55:57 2023 +0100 Bump eslint-plugin-jest from 27.1.6 to 27.2.1 (#451) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 44c9f10 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Sun Jan 22 10:55:41 2023 +0100 Bump @vercel/ncc from 0.34.0 to 0.36.0 (#448) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 247e6ab Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Sun Jan 22 10:54:44 2023 +0100 Bump globby from 13.1.2 to 13.1.3 (#449) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 0fbc920 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Thu Jan 5 20:30:42 2023 +0100 Bump @types/node from 18.11.9 to 18.11.18 (#442) Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 18.11.9 to 18.11.18. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node) --- updated-dependencies: - dependency-name: "@types/node" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 1d5c57a Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Thu Jan 5 20:30:17 2023 +0100 Bump @typescript-eslint/parser from 5.44.0 to 5.48.0 (#445) Bumps [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser) from 5.44.0 to 5.48.0. - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/parser/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v5.48.0/packages/parser) --- updated-dependencies: - dependency-name: "@typescript-eslint/parser" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit ae86d42 Author: Arnaud Benhamdine <abenhamdine@users.noreply.github.com> Date: Thu Jan 5 20:23:14 2023 +0100 Update version of futuratrepadeira/changed-files used commit d26c1aa Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Thu Jan 5 20:19:29 2023 +0100 Bump eslint from 8.28.0 to 8.31.0 (#444) Bumps [eslint](https://github.com/eslint/eslint) from 8.28.0 to 8.31.0. - [Release notes](https://github.com/eslint/eslint/releases) - [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md) - [Commits](eslint/eslint@v8.28.0...v8.31.0) --- updated-dependencies: - dependency-name: eslint dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 2e3c200 Author: Arnaud Benhamdine <arnaud.benhamdine@gmail.com> Date: Mon Nov 28 01:03:35 2022 +0100 Update readme
1 parent a38f099 commit cf31a19

File tree

11 files changed

+167865
-172564
lines changed

11 files changed

+167865
-172564
lines changed

.eslintrc.json

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@
1313
"project": "./tsconfig.json"
1414
},
1515
"rules": {
16+
"i18n-text/no-en": "off",
1617
"no-console": "off",
1718
"filenames/match-regex": "off",
1819
"github/array-foreach": "off",
@@ -21,6 +22,7 @@
2122
"eslint-comments/no-use": "off",
2223
"import/no-namespace": "off",
2324
"no-unused-vars": "off",
25+
"no-shadow": "off",
2426
"@typescript-eslint/no-unused-vars": "error",
2527
"@typescript-eslint/explicit-member-accessibility": [
2628
"error",

README.md

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ jobs:
3737
include: '["\\.ts$"]'
3838
- name: Detecting files changed
3939
id: files
40-
uses: futuratrepadeira/changed-files@v3.2.1
40+
uses: umani/changed-files@v4.0.0
4141
with:
4242
repo-token: ${{ github.token }}
4343
pattern: '^.*\.ts$'
@@ -46,7 +46,7 @@ jobs:
4646
echo 'Files modified: ${{steps.files.outputs.files_updated}}'
4747
echo 'Files added: ${{steps.files.outputs.files_created}}'
4848
echo 'Files removed: ${{steps.files.outputs.files_deleted}}'
49-
- uses: Arhia/action-check-typescript@v0.11
49+
- uses: Arhia/action-check-typescript@v1.0.0
5050
with:
5151
repo-token: ${{ secrets.GITHUB_TOKEN }}
5252
use-check: true
@@ -55,6 +55,8 @@ jobs:
5555
files-added: ${{steps.files.outputs.files_created}}
5656
files-deleted: ${{steps.files.outputs.files_deleted}}
5757
line-numbers: ${{steps.diff.outputs.lineNumbers}}
58+
output-behaviour: both
59+
comment-behaviour: new
5860
```
5961
## Customize the check
6062
@@ -82,6 +84,13 @@ Value|Behaviour
8284
`annotate` | Uses github line annotations with the errors found for this run.
8385
`both` | Does both of the above.
8486

87+
The comment behaviour depends on the value of `comment-behaviour`
88+
89+
Value|Behaviour
90+
-- | --
91+
`new` | Default, adds a new comment for every run of the action.
92+
`edit` | Updates a previous run's comment, if one exists, otherwise creates a new comment.
93+
8594
## Use a specific tsconfig file
8695

8796
By default, this actions uses tsconfig file located at './tsconfig.json'

action.yml

Lines changed: 15 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,39 +1,42 @@
1-
name: 'Action Check Typescript errors'
2-
description: 'Check tsc errors and compare errors wih base branch'
3-
author: 'Arhia'
1+
name: "Action Check Typescript errors"
2+
description: "Check tsc errors and compare errors wih base branch"
3+
author: "Arhia"
44
icon: box
55
inputs:
66
repo-token:
7-
description: 'Token for the repository. Can be passed in using {{ secrets.GITHUB_TOKEN }}'
7+
description: "Token for the repository. Can be passed in using {{ secrets.GITHUB_TOKEN }}"
88
required: true
99
directory:
1010
description: "Directory where to run install and build. Default is '.'"
11-
default: '.'
11+
default: "."
1212
files-changed:
1313
description: "List of files changed in the current PR (separated by space), use action 'futuratrepadeira/changed-files' for that"
14-
default: ''
14+
default: ""
1515
files-added:
1616
description: "List of files added in the current PR (separated by space), use action 'futuratrepadeira/changed-files' for that"
17-
default: ''
17+
default: ""
1818
files-deleted:
1919
description: "List of files deleted in the current PR (separated by space), use action 'futuratrepadeira/changed-files' for that"
20-
default: ''
20+
default: ""
2121
line-numbers:
2222
description: "List of files with added and removed lines, use action 'Equip-Collaboration/diff-line-numbers' for that"
2323
ts-config-path:
2424
description: "Path of tsconfig file. default is './tsconfig.json'"
25-
default: './tsconfig.json'
25+
default: "./tsconfig.json"
2626
use-check:
27-
description: 'Report status as a CI Check'
27+
description: "Report status as a CI Check"
2828
check-fail-mode:
2929
description: "Allowed values : added, errors_in_pr, errors_in_code"
3030
required: true
3131
output-behaviour:
3232
description: "Allowed values : comment, annotate, both"
3333
default: "comment"
34+
comment-behaviour:
35+
description: "Allowed values : new, edit"
36+
default: "new"
3437
debug:
3538
description: "Set true to log ts errors in base branch and pr branch"
3639
default: false
3740
runs:
38-
using: 'node16'
39-
main: 'dist/index.js'
41+
using: "node16"
42+
main: "dist/index.js"

0 commit comments

Comments
 (0)