From a666fed69306882ab50ce9ac8dc3f7303fe5a33f Mon Sep 17 00:00:00 2001 From: Anders Hejlsberg Date: Tue, 9 Jul 2019 10:30:03 -0700 Subject: [PATCH] Ensure tests produce same results before and after TS #32260 (#36728) --- types/storage-helper/storage-helper-tests.ts | 4 ++-- types/wordpress__hooks/wordpress__hooks-tests.ts | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/types/storage-helper/storage-helper-tests.ts b/types/storage-helper/storage-helper-tests.ts index 8a3fb9f87937b7..102eaf51614017 100644 --- a/types/storage-helper/storage-helper-tests.ts +++ b/types/storage-helper/storage-helper-tests.ts @@ -7,8 +7,8 @@ storageHelper.setItem('foo', 'bas', false); storageHelper.getItem('foo'); // $ExpectType string | null storageHelper.getItem('foo', false); // $ExpectType string | null storageHelper.getItem('foo', undefined); // $ExpectType string | null -storageHelper.getItem('foo', false, Boolean() ? 1 : undefined); // $ExpectType string | number | null -storageHelper.getItem('foo', false, 1); // $ExpectType string | number | null +storageHelper.getItem('foo', false, Boolean() ? 1 + 1 : undefined); // $ExpectType string | number | null +storageHelper.getItem('foo', false, 1 + 1); // $ExpectType string | number | null storageHelper.getItem('foo', false, undefined); // $ExpectType string | null storageHelper.getItem('foo', true); // $ExpectType any storageHelper.getItem('foo', true, 1); // $ExpectType any diff --git a/types/wordpress__hooks/wordpress__hooks-tests.ts b/types/wordpress__hooks/wordpress__hooks-tests.ts index cbecb0398f37ea..5d794c3841416b 100644 --- a/types/wordpress__hooks/wordpress__hooks-tests.ts +++ b/types/wordpress__hooks/wordpress__hooks-tests.ts @@ -89,7 +89,7 @@ hooks.filters; firstFilter('foo', 'other', 'args', 34, 'blah', true); // $ExpectType boolean - firstFilter(true); + firstFilter(1 < 2); // $ExpectType number firstFilter(123);