From 24cd81ea1f5c2e8463d38b4ebe81c05cb13df003 Mon Sep 17 00:00:00 2001 From: Anders Hejlsberg Date: Wed, 25 Sep 2019 10:34:12 -0700 Subject: [PATCH] Ensure tests of non-returning functions don't cause unreachability errors (#38596) --- types/node/v10/node-tests.ts | 6 +++--- types/vfile/vfile-tests.ts | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/types/node/v10/node-tests.ts b/types/node/v10/node-tests.ts index 15d578a0c1426d..b6b545819ba1d8 100644 --- a/types/node/v10/node-tests.ts +++ b/types/node/v10/node-tests.ts @@ -70,11 +70,11 @@ import { Buffer as ImportedBuffer, SlowBuffer as ImportedSlowBuffer, transcode, assert.equal(3, "3", "uses == comparator"); - assert.fail('stuff broke'); + if (!!true) assert.fail('stuff broke'); - assert.fail('actual', 'expected', 'message'); + if (!!true) assert.fail('actual', 'expected', 'message'); - assert.fail(1, 2, undefined, '>'); + if (!!true) assert.fail(1, 2, undefined, '>'); assert.ifError(0); diff --git a/types/vfile/vfile-tests.ts b/types/vfile/vfile-tests.ts index b89df6db231856..d33ea62f81fc23 100644 --- a/types/vfile/vfile-tests.ts +++ b/types/vfile/vfile-tests.ts @@ -40,7 +40,7 @@ file.message('test', { file.message('test', { start: 'invalid point' }); // $ExpectError -file.fail('test'); +if (!!true) file.fail('test'); const infoMessage: vfileMessage.VFileMessage = file.info('test');