Skip to content

Commit 6acbac0

Browse files
committed
m: Don't re-implement ready! and pin!
Bumps MSRV to 1.65 Signed-off-by: John Nunley <dev@notgull.net>
1 parent c48c7af commit 6acbac0

File tree

9 files changed

+9
-38
lines changed

9 files changed

+9
-38
lines changed

.github/workflows/ci.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ jobs:
7272
matrix:
7373
# When updating this, the reminder to update the minimum supported
7474
# Rust version in Cargo.toml.
75-
rust: ['1.61']
75+
rust: ['1.65']
7676
steps:
7777
- uses: actions/checkout@v4
7878
- name: Install cargo-hack

Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ name = "async-lock"
66
version = "3.4.1"
77
authors = ["Stjepan Glavina <stjepang@gmail.com>"]
88
edition = "2021"
9-
rust-version = "1.60"
9+
rust-version = "1.65"
1010
description = "Async synchronization primitives"
1111
license = "Apache-2.0 OR MIT"
1212
repository = "https://github.com/smol-rs/async-lock"

src/barrier.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ use event_listener_strategy::{easy_wrapper, EventListenerFuture, Strategy};
33

44
use core::fmt;
55
use core::pin::Pin;
6-
use core::task::Poll;
6+
use core::task::{ready, Poll};
77

88
use crate::futures::Lock;
99
use crate::Mutex;

src/lib.rs

Lines changed: 0 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -41,36 +41,6 @@
4141

4242
extern crate alloc;
4343

44-
/// Simple macro to extract the value of `Poll` or return `Pending`.
45-
///
46-
/// TODO: Drop in favor of `core::task::ready`, once MSRV is bumped to 1.64.
47-
macro_rules! ready {
48-
($e:expr) => {{
49-
use ::core::task::Poll;
50-
51-
match $e {
52-
Poll::Ready(v) => v,
53-
Poll::Pending => return Poll::Pending,
54-
}
55-
}};
56-
}
57-
58-
/// Pins a variable on the stack.
59-
///
60-
/// TODO: Drop in favor of `core::pin::pin`, once MSRV is bumped to 1.68.
61-
#[cfg(all(feature = "std", not(target_family = "wasm")))]
62-
macro_rules! pin {
63-
($($x:ident),* $(,)?) => {
64-
$(
65-
let mut $x = $x;
66-
#[allow(unused_mut)]
67-
let mut $x = unsafe {
68-
core::pin::Pin::new_unchecked(&mut $x)
69-
};
70-
)*
71-
}
72-
}
73-
7444
/// Make the given function const if the given condition is true.
7545
macro_rules! const_fn {
7646
(

src/mutex.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ use core::fmt;
44
use core::marker::{PhantomData, PhantomPinned};
55
use core::ops::{Deref, DerefMut};
66
use core::pin::Pin;
7-
use core::task::Poll;
7+
use core::task::{ready, Poll};
88

99
use alloc::sync::Arc;
1010

src/once_cell.rs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ use core::convert::Infallible;
33
use core::fmt;
44
use core::future::Future;
55
use core::mem::{forget, MaybeUninit};
6+
use core::pin::pin;
67
use core::ptr;
78

89
use crate::sync::atomic::{AtomicUsize, Ordering};
@@ -800,7 +801,7 @@ fn now_or_never<T>(f: impl Future<Output = T>) -> T {
800801
}
801802
unsafe fn drop(_: *const ()) {}
802803

803-
pin!(f);
804+
let f = pin!(f);
804805

805806
let waker = unsafe { Waker::from_raw(RawWaker::new(ptr::null(), &NOOP_WAKER)) };
806807

src/rwlock/futures.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
use core::fmt;
22
use core::mem::ManuallyDrop;
33
use core::pin::Pin;
4-
use core::task::Poll;
4+
use core::task::{ready, Poll};
55

66
use alloc::sync::Arc;
77

src/rwlock/raw.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
use core::marker::PhantomPinned;
1010
use core::mem::forget;
1111
use core::pin::Pin;
12-
use core::task::Poll;
12+
use core::task::{ready, Poll};
1313

1414
use crate::sync::atomic::{AtomicUsize, Ordering};
1515

src/semaphore.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ use core::fmt;
22
use core::marker::PhantomPinned;
33
use core::mem;
44
use core::pin::Pin;
5-
use core::task::Poll;
5+
use core::task::{ready, Poll};
66

77
use crate::sync::atomic::{AtomicUsize, Ordering};
88

0 commit comments

Comments
 (0)