chore: Bump CRT version to 0.51.0 from 0.48.0 #925
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dayaffe
approved these changes
Apr 28, 2025
jbelkins
reviewed
Apr 28, 2025
| @@ -109,4 +109,8 @@ public class StreamableHttpBody: IStreamable { | |||
| return nil | |||
| } | |||
| } | |||
|
|
|||
| public func isEndOfStream() -> Bool { | |||
| return false | |||
There was a problem hiding this comment.
What's the rationale for this always being false?
There was a problem hiding this comment.
Rationale was provided in CRT side here.
There was a problem hiding this comment.
After discussion with Waqar realized it has to have actual impl in SDK side; updated here: 55dd83c
(also see integration test failures in aws-sdk-swift) |
|
Version bump to go out with #920, as there exists a bug in 0.51.0 and fix for the bug was added by rolling forward to 0.52.1 due to branch mgmt complications. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corresponding aws-sdk-swift PR: awslabs/aws-sdk-swift#1927
Issue #
2819
Description of changes
length(). Thelength()function was the only thing we were using; so conformance was removed by CRT and that method is moved to SDK side.isEndOfStream()is added as corresponding change to CRT-side bug fix. The fix addresses CRT HTTP client issue where it used to send empty frame after every nonempty data frame in HTTP/2 connection.Scope
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.