Fix observability detection to use type-safe downcasting and remove unused business_metrics test

Author: vcjana

aws/rust-runtime/Cargo.lock

@@ -431,7 +431,7 @@ mod test {
             "debug tester",
         );
         assert_eq!(
-            format!("{:?}", creds),
+            format!("{creds:?}"),
             r#"Credentials { provider_name: "debug tester", access_key_id: "akid", secret_access_key: "** redacted **", expires_after: "2009-02-13T23:31:30Z" }"#
         );
 
@@ -445,7 +445,7 @@ mod test {
             .provider_name("debug tester")
             .build();
         assert_eq!(
-            format!("{:?}", creds),
+            format!("{creds:?}"),
             r#"Credentials { provider_name: "debug tester", access_key_id: "akid", secret_access_key: "** redacted **", expires_after: "2009-02-13T23:31:30Z", account_id: "012345678901" }"#
         );
     }

aws/rust-runtime/aws-credential-types/src/credentials_impl.rs

@@ -180,7 +180,7 @@ mod tests {
         let mut file = NamedTempFile::new().unwrap();
 
         for i in 0..10000 {
-            let line = format!("This is a large file created for testing purposes {}", i);
+            let line = format!("This is a large file created for testing purposes {i}");
             file.as_file_mut().write_all(line.as_bytes()).unwrap();
         }
 
@@ -302,7 +302,7 @@ mod tests {
     async fn streaming_body(path: impl AsRef<std::path::Path>) -> SdkBody {
         let file = path.as_ref();
         ByteStream::read_from()
-            .path(&file)
+            .path(file)
             .build()
             .await
             .unwrap()

aws/rust-runtime/aws-inlineable/src/aws_chunked.rs

@@ -427,6 +427,7 @@ mod tests {
     use http_body::Body;
     use tempfile::NamedTempFile;
 
+    #[allow(clippy::type_complexity)]
     fn create_test_interceptor() -> RequestChecksumInterceptor<
         impl Fn(&Input) -> (Option<String>, bool) + Send + Sync,
         impl Fn(&mut Request, &ConfigBag) -> Result<bool, BoxError> + Send + Sync,
@@ -449,7 +450,7 @@ mod tests {
 
         let mut crc32c_checksum = checksum_algorithm.into_impl();
         for i in 0..10000 {
-            let line = format!("This is a large file created for testing purposes {}", i);
+            let line = format!("This is a large file created for testing purposes {i}");
             file.as_file_mut().write_all(line.as_bytes()).unwrap();
             crc32c_checksum.update(line.as_bytes());
         }
@@ -495,7 +496,7 @@ mod tests {
             body_data.extend_from_slice(&data.unwrap())
         }
         let body_str = std::str::from_utf8(&body_data).unwrap();
-        let expected = format!("This is a large file created for testing purposes 9999");
+        let expected = "This is a large file created for testing purposes 9999".to_string();
         assert!(
             body_str.ends_with(&expected),
             "expected '{body_str}' to end with '{expected}'"

aws/rust-runtime/aws-inlineable/src/http_request_checksum.rs

@@ -22,7 +22,6 @@ aws-smithy-async = { path = "../../../rust-runtime/aws-smithy-async" }
 aws-smithy-eventstream = { path = "../../../rust-runtime/aws-smithy-eventstream", optional = true }
 aws-smithy-http = { path = "../../../rust-runtime/aws-smithy-http" }
 aws-smithy-observability = { path = "../../../rust-runtime/aws-smithy-observability" }
-aws-smithy-observability-otel = { path = "../../../rust-runtime/aws-smithy-observability-otel" }
 aws-smithy-runtime = { path = "../../../rust-runtime/aws-smithy-runtime", features = ["client"] }
 aws-smithy-runtime-api = { path = "../../../rust-runtime/aws-smithy-runtime-api", features = ["client"] }
 aws-smithy-types = { path = "../../../rust-runtime/aws-smithy-types" }
@@ -39,6 +38,9 @@ regex-lite = { version = "0.1.5", optional = true }
 tracing = "0.1.40"
 uuid = { version = "1" }
 
+[target.'cfg(all(not(target_arch = "powerpc"), not(target_family = "wasm")))'.dependencies]
+aws-smithy-observability-otel = { path = "../../../rust-runtime/aws-smithy-observability-otel" }
+
 [dev-dependencies]
 arbitrary = "1.3"
 aws-credential-types = { path = "../aws-credential-types", features = ["test-util"] }
@@ -52,6 +54,7 @@ futures-util = { version = "0.3.29", default-features = false }
 proptest = "1.2"
 serde = { version = "1", features = ["derive"]}
 serde_json = "1"
+serial_test = "3"
 tokio = { version = "1.23.1", features = ["macros", "rt", "time"] }
 tracing-subscriber = { version = "0.3.17", features = ["env-filter"] }
 tracing-test = "0.2.4"

aws/rust-runtime/aws-runtime/Cargo.toml

@@ -153,7 +153,7 @@ mod tests {
             .load::<AwsSdkFeature>()
             .cloned()
             .collect();
-        assert_eq!(features.len(), 1, "Expected 1 feature, got: {:?}", features);
+        assert_eq!(features.len(), 1, "Expected 1 feature, got: {features:?}");
         assert_eq!(features[0], AwsSdkFeature::EndpointOverride);
     }
 }

aws/rust-runtime/aws-runtime/src/endpoint_override.rs

@@ -292,7 +292,7 @@ mod test {
         let tests = fs::read_to_string("test-data/profile-parser-tests.json")?;
         let tests: ParserTests = serde_json::from_str(&tests)?;
         for (i, test) in tests.tests.into_iter().enumerate() {
-            eprintln!("test: {}", i);
+            eprintln!("test: {i}");
             check(test);
         }
         Ok(())
@@ -432,22 +432,22 @@ mod test {
                 }
             }
             (Err(msg), ParserOutput::ErrorContaining(substr)) => {
-                if format!("{}", msg).contains(substr) {
+                if format!("{msg}").contains(substr) {
                     Ok(())
                 } else {
-                    Err(format!("Expected {} to contain {}", msg, substr))
+                    Err(format!("Expected {msg} to contain {substr}"))
                 }
             }
             (Ok(output), ParserOutput::ErrorContaining(err)) => Err(format!(
                 "expected an error: {err} but parse succeeded:\n{output:#?}",
             )),
             (Err(err), ParserOutput::Config { .. }) => {
-                Err(format!("Expected to succeed but got: {}", err))
+                Err(format!("Expected to succeed but got: {err}"))
             }
         };
         if let Err(e) = res {
-            eprintln!("Test case failed: {:#?}", copy);
-            eprintln!("failure: {}", e);
+            eprintln!("Test case failed: {copy:#?}");
+            eprintln!("failure: {e}");
             panic!("test failed")
         }
     }

aws/rust-runtime/aws-runtime/src/env_config/section.rs

@@ -245,7 +245,7 @@ mod tests {
         let tests = fs::read_to_string("test-data/file-location-tests.json")?;
         let tests: SourceTests = serde_json::from_str(&tests)?;
         for (i, test) in tests.tests.into_iter().enumerate() {
-            eprintln!("test: {}", i);
+            eprintln!("test: {i}");
             check(test)
                 .now_or_never()
                 .expect("these futures should never poll");