src/bam_record_utils.hpp: fixing the use of bool values in less-than comparison

andrewdavidsmith · andrewdavidsmith · commit 0f896afc755d · 2024-10-19T19:27:15.000-07:00
diff --git a/src/bam_record_utils.hpp b/src/bam_record_utils.hpp
@@ -250,7 +250,8 @@ inline bool
 precedes_by_end_and_strand(const bamxx::bam_rec &a, const bamxx::bam_rec &b) {
   const auto end_a = bam_endpos(a.b);
   const auto end_b = bam_endpos(b.b);
-  return end_a < end_b || (end_a == end_b && bam_is_rev(a) < bam_is_rev(b));
+  return end_a < end_b ||
+         (end_a == end_b && bam_is_rev(a) == false && bam_is_rev(b) == true);
 }
 
 inline bool

Original file line number	Diff line number	Diff line change
`@@ -250,7 +250,8 @@ inline bool`
`250`	`250`	`precedes_by_end_and_strand(const bamxx::bam_rec &a, const bamxx::bam_rec &b) {`
`251`	`251`	`const auto end_a = bam_endpos(a.b);`
`252`	`252`	`const auto end_b = bam_endpos(b.b);`
`253`		`- return end_a < end_b \|\| (end_a == end_b && bam_is_rev(a) < bam_is_rev(b));`
	`253`	`+ return end_a < end_b \|\|`
	`254`	`+ (end_a == end_b && bam_is_rev(a) == false && bam_is_rev(b) == true);`
`254`	`255`	`}`
`255`	`256`
`256`	`257`	`inline bool`