add flag that forces clean sessions per invocation

Author: smithclay

index.js

@@ -8,16 +8,18 @@ const log = require('lambda-log');
 
 log.info('Loading function');
 
-// Create new session (spawns chromium and webdriver)
-$browser = chromium.createSession();
+// Create new reusable session (spawns chromium and webdriver)
+if (!process.env.CLEAN_SESSIONS) {
+  $browser = chromium.createSession();
+}
 
 exports.handler = (event, context, callback) => {
   context.callbackWaitsForEmptyEventLoop = false;
 
-  /*if (process.env.CLEAR_TMP) {
+  if (process.env.CLEAN_SESSIONS) {
     log.info('attempting to clear /tmp directory')
     log.info(child.execSync('rm -rf /tmp/core*').toString());
-  }*/
+  }
 
   if (process.env.DEBUG_ENV || process.env.SAM_LOCAL) {
     log.config.debug = true;
@@ -41,6 +43,11 @@ exports.handler = (event, context, callback) => {
   const inputBuffer = Buffer.from(inputParam, 'base64').toString('utf8');
   log.debug(`Executing script "${inputBuffer}"`);
 
+  // Creates a new session on each event (instead of reusing for performance benefits)
+  if (process.env.CLEAN_SESSIONS) {
+    $browser = chromium.createSession();
+  }
+
   sandbox.executeScript(inputBuffer, $browser, webdriver, function(err) {
     if (process.env.LOG_DEBUG) {
       log.debug(child.execSync('ps aux').toString());

lib/sandbox.js

@@ -30,11 +30,17 @@ exports.executeScript = function(scriptText, browser, driver, cb) {
   */
   // https://github.com/GoogleChrome/puppeteer/issues/1825#issuecomment-372241101
   // Reuse existing session, likely some edge cases around this...
-  browser.manage().deleteAllCookies().then(function() {
-    return $browser.get('about:blank').then(function() {
+  if (process.env.CLEAN_SESSIONS) {
+    $browser.quit().then(function() {
       cb(null);
-    }).catch(function(err) {
-      cb(err);
     });
-  });
-}
+  } else {
+    browser.manage().deleteAllCookies().then(function() {
+      return $browser.get('about:blank').then(function() {
+        cb(null);
+      }).catch(function(err) {
+        cb(err);
+      });
+    });
+  }
+}