-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes made for travis CI break up developing this gem #12
Comments
Ah thanks for pointing that out. The reason I included bundler as a dependency is that CI was failing, maybe if I use a more recent version of ruby that won't happen? |
Everytime freezing bundler on specific version is wrong, because each time after new bundler is released then you must update repo, which isn't good. There must be better solution. |
@wafcio I think the latest commit should fix this issue. |
@smcabrera You added |
Ah good catch, thanks |
In gemspec you froze bundler version which is old right now. I tried to use old bundler version but all time it use the newest version in my system. I think it should be removed from gemspec too. |
@smcabrera a few things connected with yout changes for travis:
.ruby-version
file isn't necesary if you defined rvm section. Ruby 2.2.4 is little old, there should be defined more ruby version for travis.bundle
command. I think taht it can be achieved in different way for Travis CIThe text was updated successfully, but these errors were encountered: