Merge pull request #8 from dev-diaries41/refactor/embeddingstore

update: in test pass file directly to create embedding store

Author: dev-diaries41

extensions/src/androidTest/kotlin/com/fpf/smartscansdk/extensions/embeddings/EmbeddingLoadingBenchmarkTest.kt

@@ -52,14 +52,14 @@ class EmbeddingLoadingBenchmarkTest {
 
 
 
-        val tempDir = File(context.cacheDir, "tempEmbeddings").apply { mkdirs() }
-        val store = FileEmbeddingStore(tempDir, "embeddings.bin", embeddingLength)
+        val embeddingsFile = File(context.cacheDir, "embeddings.bin")
+        val store = FileEmbeddingStore(embeddingsFile,  embeddingLength)
 
         store.add(embeddings.map { it.toEmbedding() })
         store.clear() // force reload
 
         val fileTime = measureNanoTime {
-            val loadedFile = store.getAll()
+            val loadedFile = store.get()
             assertEquals(numEmbeddings, loadedFile.size)
         }
 

extensions/src/test/kotlin/com/fpf/smartscansdk/extensions/embeddings/FileEmbeddingRetriever.kt

@@ -20,8 +20,8 @@ class FileEmbeddingRetrieverTest {
     private fun embedding(id: Long, date: Long, values: FloatArray) =
         Embedding(id, date, values)
 
-    private fun createStore(fileName: String = "embeddings.bin") =
-        FileEmbeddingStore(tempDir, fileName, embeddingLength)
+    private fun createStore(file: File = File(tempDir, "embeddings.bin"), useCache: Boolean = true) =
+        FileEmbeddingStore(file, embeddingLength, useCache = useCache)
 
     @Test
     fun `query batch retrieval with start and end works`() = runTest {

extensions/src/test/kotlin/com/fpf/smartscansdk/extensions/embeddings/FileEmbeddingStoreTest.kt

@@ -36,8 +36,8 @@ class FileEmbeddingStoreTest {
 
     private val embeddingLength = 4
 
-    private fun createStore(fileName: String = "embeddings.bin", useCache: Boolean = true) =
-        FileEmbeddingStore(tempDir, fileName, embeddingLength, useCache = useCache)
+    private fun createStore(file: File = File(tempDir, "embeddings.bin"), useCache: Boolean = true) =
+        FileEmbeddingStore(file, embeddingLength, useCache = useCache)
 
     private fun embedding(id: Long, date: Long, values: FloatArray) =
         Embedding(id, date, values)