Skip to content

Commit dfa969f

Browse files
committed
Remove unneeded nmap.h and global_structures.h includes in .h files
1 parent cfe8893 commit dfa969f

17 files changed

+8
-33
lines changed

FingerPrintResults.h

-2
Original file line numberDiff line numberDiff line change
@@ -128,8 +128,6 @@
128128

129129
class FingerPrintResults;
130130

131-
#include "nmap.h"
132-
#include "global_structures.h"
133131
#include "FPEngine.h"
134132

135133
/* Maximum number of results allowed in one of these things ... */

NmapOps.h

-2
Original file line numberDiff line numberDiff line change
@@ -126,8 +126,6 @@
126126
#ifndef NMAP_OPS_H
127127
#define NMAP_OPS_H
128128

129-
#include "nmap.h"
130-
#include "global_structures.h"
131129
#include "output.h"
132130
#include <nsock.h>
133131
#include <string>

NmapOutputTable.h

+4-1
Original file line numberDiff line numberDiff line change
@@ -126,7 +126,10 @@
126126
#ifndef NMAPOUTPUTTABLE_H
127127
#define NMAPOUTPUTTABLE_H
128128

129-
#include "nmap.h"
129+
/* Keep assert() defined for security reasons */
130+
#undef NDEBUG
131+
132+
#include <assert.h>
130133

131134
/********************** DEFINES/ENUMS ***********************************/
132135

Target.h

-1
Original file line numberDiff line numberDiff line change
@@ -127,7 +127,6 @@
127127
#ifndef TARGET_H
128128
#define TARGET_H
129129

130-
#include "nmap.h"
131130
#include "FingerPrintResults.h"
132131
#include "libnetutil/netutil.h"
133132

TargetGroup.h

-2
Original file line numberDiff line numberDiff line change
@@ -135,8 +135,6 @@
135135
#include <set>
136136
#include <string>
137137

138-
#include "nmap.h"
139-
140138
/* We use bit vectors to represent what values are allowed in an IPv4 octet.
141139
Each vector is built up of an array of bitvector_t (any convenient integer
142140
type). */

idle_scan.h

-2
Original file line numberDiff line numberDiff line change
@@ -130,8 +130,6 @@
130130
#ifndef IDLE_SCAN_H
131131
#define IDLE_SCAN_H
132132

133-
#include "nmap.h"
134-
#include "global_structures.h"
135133
#include <nbase.h>
136134

137135
class Target;

osscan.h

-2
Original file line numberDiff line numberDiff line change
@@ -126,8 +126,6 @@
126126
#ifndef OSSCAN_H
127127
#define OSSCAN_H
128128

129-
#include "nmap.h"
130-
#include "global_structures.h"
131129
#include "FingerPrintResults.h"
132130
#include "Target.h"
133131

osscan2.h

-2
Original file line numberDiff line numberDiff line change
@@ -127,8 +127,6 @@
127127
#ifndef OSSCAN2_H
128128
#define OSSCAN2_H
129129

130-
#include "nmap.h"
131-
#include "global_structures.h"
132130
#include "nbase.h"
133131
#include <vector>
134132
#include <list>

output.h

-2
Original file line numberDiff line numberDiff line change
@@ -163,8 +163,6 @@
163163
"use \"-Pn -sT localhost\" though.\n\n"
164164

165165
#include "portlist.h"
166-
#include "nmap.h"
167-
#include "global_structures.h"
168166
#include <nsock.h>
169167

170168
#include <string>

portreasons.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -127,7 +127,7 @@
127127
#ifndef REASON_H
128128
#define REASON_H
129129

130-
#include "nmap.h"
130+
#include "nbase.h"
131131

132132
#ifdef WIN32
133133
#include "winsock2.h"

protocols.h

-2
Original file line numberDiff line numberDiff line change
@@ -130,8 +130,6 @@
130130
#include <netdb.h>
131131
#endif
132132

133-
#include "nmap.h"
134-
#include "global_structures.h"
135133
#include "nbase.h"
136134

137135
#define PROTOCOL_TABLE_SIZE 256

scan_engine.h

-2
Original file line numberDiff line numberDiff line change
@@ -127,8 +127,6 @@
127127
#ifndef SCAN_ENGINE_H
128128
#define SCAN_ENGINE_H
129129

130-
#include "nmap.h"
131-
#include "global_structures.h"
132130
#include "timing.h"
133131
#include "tcpip.h"
134132
#include <list>

service_scan.h

-2
Original file line numberDiff line numberDiff line change
@@ -127,8 +127,6 @@
127127
#ifndef SERVICE_SCAN_H
128128
#define SERVICE_SCAN_H
129129

130-
#include "nmap.h"
131-
#include "global_structures.h"
132130
#include "portlist.h"
133131

134132
#include <vector>

services.h

-2
Original file line numberDiff line numberDiff line change
@@ -132,8 +132,6 @@
132132
#else
133133
#include <netdb.h>
134134
#endif
135-
#include "nmap.h"
136-
#include "global_structures.h"
137135

138136
#include "nbase.h"
139137

targets.h

+2-2
Original file line numberDiff line numberDiff line change
@@ -147,10 +147,10 @@
147147
#include <sys/param.h> /* Defines MAXHOSTNAMELEN on BSD*/
148148
#endif
149149

150-
#include "nmap.h"
151-
#include "global_structures.h"
152150
#include "TargetGroup.h"
153151

152+
class Target;
153+
154154
class TargetGroup {
155155
public:
156156
NetBlock *netblock;

tcpip.h

+1-4
Original file line numberDiff line numberDiff line change
@@ -219,10 +219,7 @@ extern "C" {
219219
#include <signal.h>
220220
#include <dnet.h>
221221

222-
223-
224-
#include "nmap.h"
225-
#include "global_structures.h"
222+
class Target;
226223

227224
#ifndef INET_ADDRSTRLEN
228225
#define INET_ADDRSTRLEN 16

utils.h

-2
Original file line numberDiff line numberDiff line change
@@ -130,7 +130,6 @@
130130
#include <string.h>
131131
#include <errno.h>
132132
#include <ctype.h>
133-
#include "nmap.h"
134133
#ifdef WIN32
135134
#include "mswin32\winclude.h"
136135
#else
@@ -162,7 +161,6 @@
162161
#include "nbase.h"
163162

164163
#include "nmap_error.h"
165-
#include "global_structures.h"
166164

167165
/* Arithmatic difference modulo 2^32 */
168166
#ifndef MOD_DIFF

0 commit comments

Comments
 (0)