Merge pull request #257 from smartdevicelink/feature/message-versioning

Add non-static consumer message versioning

Author: crokita

app/v1/messages/sql.js

@@ -22,7 +22,8 @@ module.exports = {
         categoryByLanguage: getMessageCategoriesByLanguage,
         categoryByMaxId: getMessageCategoriesByMaxId,
         byIds: getMessagesByIdsStagingFilter,
-        groupsByIds: getMessageGroupsByIdsStagingFilter
+        groupsByIds: getMessageGroupsByIdsStagingFilter,
+        highestGroupId: getHighestMessageGroupId,
     },
     getMessageNamesStaging: getMessageNamesStaging,
     getLanguages: getLanguages,
@@ -44,6 +45,16 @@ function getMessagesStatus (isProduction) {
     }
 }
 
+//retrieve the highest id message group found
+function getHighestMessageGroupId (isProduction) {
+    let viewName = isProduction ? 'view_message_group_production' : 'view_message_group_staging';
+
+    let sqlString = sql.select('MAX(id) AS id')
+        .from(viewName);
+
+    return sqlString.toString();
+}
+
 //retrieve message group information such as categories
 function getMessageGroups (isProduction, category, hideDeleted = false) {
     let viewName = isProduction ? 'view_message_group_production' : 'view_message_group_staging';

app/v1/policy/helper.js

@@ -119,7 +119,8 @@ function setupModuleConfig (isProduction, useLongUuids = false) {
 function setupConsumerFriendlyMessages (isProduction) {
     const getMessages = flame.flow({
         messageStatuses: setupSqlCommand.bind(null, messagesSql.getMessages.status(isProduction)),
-        messageGroups: setupSqlCommand.bind(null, messagesSql.getMessages.group(isProduction, false, true))
+        messageGroups: setupSqlCommand.bind(null, messagesSql.getMessages.group(isProduction, false, true)),
+        highestMessageGroupId: setupSqlCommand.bind(null, messagesSql.getMessages.highestGroupId(isProduction, false))
     }, {method: 'parallel'});
 
     const makeMessages = [

app/v1/policy/model.js

@@ -127,6 +127,8 @@ function transformModuleConfig (isProduction, useLongUuids = false, info, next)
 function transformMessages (info, cb) {
     const allMessages = info.messageStatuses;
     const groups = info.messageGroups;
+    const highestMessageGroupId = info.highestMessageGroupId[0] ? info.highestMessageGroupId[0].id : 0; // used to help generate a version number
+    const versionString = Number(highestMessageGroupId).toLocaleString().replace(/,/g,'.').padStart(11, "000."); // ###.###.### format up to the id of 999,999,999 
 
     const transformFlow = flame.flow([
         //hash the message groups by message_category
@@ -159,7 +161,7 @@ function transformMessages (info, cb) {
                 next();
             }, function () {
                 next(null, {
-                    "version": "000.000.001", //TODO: what to do with the versioning?
+                    "version": versionString,
                     "messages": messageObj
                 });
             });