-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add audio requirement ability #1085
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
joeygrover
changed the title
[WIP] Add audio requirement ability
Add audio requirement ability
Jun 12, 2019
joeygrover
force-pushed
the
feature/audio_requirement
branch
from
June 13, 2019 20:48
3c1a074
to
332344c
Compare
Codecov Report
@@ Coverage Diff @@
## develop #1085 +/- ##
=============================================
+ Coverage 46.7% 46.76% +0.06%
- Complexity 3860 3879 +19
=============================================
Files 440 441 +1
Lines 21113 21234 +121
Branches 2335 2360 +25
=============================================
+ Hits 9860 9931 +71
- Misses 10699 10732 +33
- Partials 554 571 +17
Continue to review full report at Codecov.
|
BrettyWhite
suggested changes
Jun 17, 2019
android/sdl_android/src/main/java/com/smartdevicelink/SdlConnection/SdlSession2.java
Outdated
Show resolved
Hide resolved
android/sdl_android/src/main/java/com/smartdevicelink/managers/SdlManager.java
Outdated
Show resolved
Hide resolved
android/sdl_android/src/main/java/com/smartdevicelink/util/MediaStreamingStatus.java
Outdated
Show resolved
Hide resolved
android/sdl_android/src/main/java/com/smartdevicelink/util/MediaStreamingStatus.java
Outdated
Show resolved
Hide resolved
android/sdl_android/src/main/java/com/smartdevicelink/util/MediaStreamingStatus.java
Outdated
Show resolved
Hide resolved
android/sdl_android/src/main/java/com/smartdevicelink/util/MediaStreamingStatus.java
Outdated
Show resolved
Hide resolved
android/sdl_android/src/main/java/com/smartdevicelink/util/MediaStreamingStatus.java
Outdated
Show resolved
Hide resolved
android/sdl_android/src/main/java/com/smartdevicelink/util/MediaStreamingStatus.java
Outdated
Show resolved
Hide resolved
android/sdl_android/src/main/java/com/smartdevicelink/util/MediaStreamingStatus.java
Outdated
Show resolved
Hide resolved
BrettyWhite
approved these changes
Jun 17, 2019
BrettyWhite
approved these changes
Jun 17, 2019
BrettyWhite
approved these changes
Jun 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1056 (partly)
This PR is ready for review.
Risk
This PR makes minor API changes.
Testing Plan
MEDIA
MEDIA with flag override
MultiplexTransportConfig.setRequiresAudioSupport(false);
NON-MEDIA - AOA no audio
NON-MEDIA - AOA with audio
Summary
Changelog
Enhancements
CLA