Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add audio requirement ability #1085

Merged
merged 12 commits into from
Jun 17, 2019
Merged

Add audio requirement ability #1085

merged 12 commits into from
Jun 17, 2019

Conversation

joeygrover
Copy link
Member

@joeygrover joeygrover commented May 31, 2019

Fixes #1056 (partly)

This PR is ready for review.

Risk

This PR makes minor API changes.

Testing Plan

MEDIA

  1. Set test app to Media using multiplexing
  2. Turn off bluetooth adapter
  3. Connect AOA through multiplexing, observe test app did not register
  4. Turn on bluetooth and allow to connect to device
  5. If app does not register automatically, open the manually and observe it did register
  6. Turn off bluetooth adapter, observe app unregisters

MEDIA with flag override

  1. Set test app to Media using multiplexing
  2. In multiplex config set flag to false MultiplexTransportConfig.setRequiresAudioSupport(false);
  3. Turn off bluetooth adapter
  4. Connect AOA through multiplexing, observe test app did register

NON-MEDIA - AOA no audio

  1. Set test app to Non-Media using multiplexing
  2. Turn off bluetooth adapter
  3. Connect AOA through multiplexing, observe test app did register

NON-MEDIA - AOA with audio

  1. Set test app to Non-Media using multiplexing
  2. Connect bluetooth to A2DP Device without connecting SDL spp (ie BT headphones)
  3. Connect AOA through multiplexing, observe test app did register

Summary

  • Added ability to require an audio output device. Default is False except for MEDIA apps where it is set to true. Developers can override this flag in either case.
  • Added a class to help track audio device status

Changelog

Enhancements
  • Apps can ensure an acceptable audio device is connected when connecting through SDL if they wish.

CLA

@joeygrover joeygrover changed the title [WIP] Add audio requirement ability Add audio requirement ability Jun 12, 2019
@codecov-io
Copy link

Codecov Report

Merging #1085 into develop will increase coverage by 0.06%.
The diff coverage is 58.67%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #1085      +/-   ##
=============================================
+ Coverage       46.7%   46.76%   +0.06%     
- Complexity      3860     3879      +19     
=============================================
  Files            440      441       +1     
  Lines          21113    21234     +121     
  Branches        2335     2360      +25     
=============================================
+ Hits            9860     9931      +71     
- Misses         10699    10732      +33     
- Partials         554      571      +17
Impacted Files Coverage Δ Complexity Δ
...devicelink/transport/MultiplexTransportConfig.java 69.76% <100%> (+3.1%) 12 <2> (+2) ⬆️
...com/smartdevicelink/SdlConnection/SdlSession2.java 15.23% <26.66%> (+1.9%) 7 <3> (+1) ⬆️
...com/smartdevicelink/util/MediaStreamingStatus.java 61.76% <61.76%> (ø) 16 <16> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23bb686...332344c. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants