Feature/widget support #2218

mked-luxoft · 2019-07-31T15:01:32Z

ATF Test Scripts to check #2918

This PR is [ready] for review.

Summary

Scripts for [SDL 0216] - Widget support feature

ATF version

develop

Manual checklist with screenshots

TBA

Changelog

Enhancements

Added expectation return into existing utils.wait() function

Bug Fixes

Added additional timeout into existing actions.allowSDL() function which is required to fix SDL issue for policies in EXTERNAL_PROPRIETARY flow

CLA

I have signed the CLA

AStasiuk · 2019-08-05T07:17:21Z

@theresalech, this PR is already reviewed and approved by Ford (by @kshala-ford) and ready for Livio review.

Jack-Byrne · 2019-08-12T15:34:22Z

test_scripts/WidgetSupport/Capabilities/006_GetSC_subscription_ignored.lua

+common.Step("SDL transfers OnSCU notification", sendOnSCU, { 1 })
+common.Step("App sends GetSC RPC for DISPLAYS, no subscribe", sendGetSC, { "DISPLAYS", nil })
+common.Step("SDL transfers OnSCU notification", sendOnSCU, { 2 })
+common.Step("App sends GetSC RPC for DISPLAYS, subscribe=true", sendGetSC, { "DISPLAYS", true })


I think this test should at least check for the info string

"Subscribe parameter is ignored. Auto Subscription/Unsubscription is used for DISPLAY capability type."

@JackLivio Please find update in 89f5721

Jack-Byrne · 2019-08-12T18:11:20Z

...Support/CreateWindow/010_Success_create_primary_widget_with_a_different_windowName_value.lua

+--[[ Local Variables ]]
+local params = {
+  windowID = 1,
+  windowName = "Name of the primary widget",


Shouldn't this case be a failure? Proposal hints at the primary widget and needing the same name.

From the proposal:

The primary widget is a special widget, that can be associated with a service type, which is used by the HMI whenever a single widget needs to represent the whole app. The primary widget should be named as the app and can be pre-created by the HMI.

@JackLivio It was agreed with proposal author that SDL should not validate WindowName for all WIndowIDs = 1 (thus for all PRIMARY WIDGETS).
Mostly by the reason that the name of the main window matches the app name.

dboltovskyi · 2019-08-13T19:59:11Z

@JackLivio Please note one script was updated in 626def3 to verify case described in smartdevicelink/sdl_core#2980 (comment)

dboltovskyi · 2019-08-14T13:03:51Z

@JackLivio Please note same script was extended to check cases with deleted windows

Jack-Byrne · 2019-08-14T19:17:11Z

I had an issue with this test.

==============================
Start './test_scripts/WidgetSupport/Capabilities/006_GetSC_subscription_ignored.lua'
==============================
=====================================================================================================
Description: ATF test script
Severity: Major
=====================================================================================================
--- Precondition ------------------------------------------------------------------------------------
kill: (52705): No such process
[14:34:13,244] Clean_environment_and_Back_up_update_PPT                                              [SUCCESS] (3 ms)
SDL pid 52718
tcp        0      0 127.0.0.1:8087          0.0.0.0:*               LISTEN     
HMI initialized
HMI is ready
Mobile connected
[14:34:14,919] Start_SDL__HMI__connect_Mobile__start_Session                                         [SUCCESS] (999 ms)
[14:34:15,965] App_registration                                                                      [SUCCESS] (286 ms)
[14:34:16,253] HMI_sends_capabilities_for_main_window                                                [SUCCESS] (30 ms)
[14:34:16,284] App_activation                                                                        [SUCCESS] (2006 ms)
--- Test --------------------------------------------------------------------------------------------
[14:34:18,291] Create_widget_1                                                                       [SUCCESS] (79 ms)
[14:34:18,374] App_sends_GetSC_RPC_for_DISPLAYS__subscribe_nil                                       [FAIL] (60 ms)
 Response to 4: ValidIf: 
number of array elements payload.systemCapability.displayCapabilities.1.windowCapabilities: expected 2, actual: 1
[14:34:18,435] Create_widget_2                                                                       [SUCCESS] (116 ms)
[14:34:18,552] App_sends_GetSC_RPC_for_DISPLAYS__subscribe_true                                      [FAIL] (61 ms)
 Response to 6: ValidIf: 
number of array elements payload.systemCapability.displayCapabilities.1.windowCapabilities: expected 3, actual: 1
[14:34:18,614] Create_widget_3                                                                       [SUCCESS] (117 ms)
[14:34:18,732] App_sends_GetSC_RPC_for_DISPLAYS__subscribe_false                                     [FAIL] (71 ms)
 Response to 8: ValidIf: 
number of array elements payload.systemCapability.displayCapabilities.1.windowCapabilities: expected 4, actual: 1
[14:34:18,805] Create_widget_4                                                                       [SUCCESS] (126 ms)
[14:34:18,931] App_sends_GetSC_RPC_for_DISPLAYS__subscribe_nil                                       [FAIL] (63 ms)
 Response to 10: ValidIf: 
number of array elements payload.systemCapability.displayCapabilities.1.windowCapabilities: expected 5, actual: 1
[14:34:18,995] Delete_widget_1                                                                       [SUCCESS] (2009 ms)
[14:34:21,006] App_sends_GetSC_RPC_for_DISPLAYS__subscribe_nil                                       [FAIL] (48 ms)
 Response to 12: ValidIf: 
number of array elements payload.systemCapability.displayCapabilities.1.windowCapabilities: expected 4, actual: 1
[14:34:21,055] Delete_widget_2                                                                       [SUCCESS] (2008 ms)
[14:34:23,063] App_sends_GetSC_RPC_for_DISPLAYS__subscribe_true                                      [FAIL] (49 ms)
 Response to 14: ValidIf: 
number of array elements payload.systemCapability.displayCapabilities.1.windowCapabilities: expected 3, actual: 1
[14:34:23,114] Delete_widget_3                                                                       [SUCCESS] (2008 ms)
[14:34:25,122] App_sends_GetSC_RPC_for_DISPLAYS__subscribe_false                                     [FAIL] (50 ms)
 Response to 16: ValidIf: 
number of array elements payload.systemCapability.displayCapabilities.1.windowCapabilities: expected 2, actual: 1
[14:34:25,174] Delete_widget_4                                                                       [SUCCESS] (2009 ms)
[14:34:27,186] App_sends_GetSC_RPC_for_DISPLAYS__subscribe_nil                                       [FAIL] (50 ms)
 Response to 18: ValidIf: 
payload.systemCapability.displayCapabilities.1.windowCapabilities.1.templatesAvailable.1: expected: Template_0, actual value: Template_4
--- Postconditions ----------------------------------------------------------------------------------
Mobile session 1 deleted
malloc_consolidate(): invalid chunk size
[14:34:27,237] Stop_SDL__restore_SDL_settings_and_PPT                                                [SUCCESS] (4034 ms)

dboltovskyi · 2019-08-14T19:34:45Z

@JackLivio That's right since fix in sdl_core has not committed yet.

dboltovskyi · 2019-08-15T18:44:00Z

@JackLivio Please notice 2 additional scripts were introduced in 1c3147a to cover specific cases described in comments below:

1) https://github.com/smartdevicelink/sdl_core/pull/2980#issuecomment-520884024
2) https://github.com/smartdevicelink/sdl_core/pull/2980#issuecomment-520889265
3) https://github.com/smartdevicelink/sdl_core/pull/2980#issuecomment-520967303

All scripts related to feature can be run on a latest SDL commit: smartdevicelink/sdl_core@ee4e1c7

…idget windows

dboltovskyi · 2019-08-21T13:26:45Z

Please notice PR is re-based onto HEAD of develop

dboltovskyi · 2019-08-23T15:50:16Z

Please notice additional script was added in (85d700f) in order to cover cases discussed in

dboltovskyi · 2019-08-24T15:21:08Z

Expected HMI level is corrected due to SDL requirement:

SDL must resume HMILevel of the application that satisfies the conditions of HMILevel Resumption independently on whether this applications registers with valid or invalid or omitted hashID

mked-luxoft mentioned this pull request Jul 31, 2019

Feature/widget support smartdevicelink/sdl_core#2980

Merged

1 task

mked-luxoft requested a review from kshala-ford August 1, 2019 09:44

kshala-ford approved these changes Aug 1, 2019

View reviewed changes

Jack-Byrne reviewed Aug 12, 2019

View reviewed changes

dboltovskyi and others added 10 commits August 20, 2019 09:41

Update existing common modules

3e4dc57

Update existing scripts for SetDisplayLayout

0d98c47

Add new scripts for Widget Support feature

35908c4

added rename for parameter DISPLAY to DISPLAYS

bfe5838

Add scripts for Button events

7208062

Add verification on info parameter

666373c

Update script to check a few window capabilities

1578664

Extend script to check a few window capabilities including DeleteWindow

929b28d

Add scripts on same associatedServiceType and max number of allowed w…

a8bd4dd

…idget windows

Update expected result code to SUCCESS for old apps

46848d9

dboltovskyi force-pushed the feature/widget_support branch from 1c3147a to 46848d9 Compare August 21, 2019 13:25

Add script to cover wrong hashId case in resumption

85d700f

Correct expected resumed HMI level

567ba9b

Fix instability of smoke tests on EXT policy mode

be162f5

Jack-Byrne approved these changes Aug 26, 2019

View reviewed changes

Jack-Byrne merged commit d74a0f4 into develop Aug 26, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/widget support #2218

Feature/widget support #2218

mked-luxoft commented Jul 31, 2019 •

edited

Loading

AStasiuk commented Aug 5, 2019

Jack-Byrne Aug 12, 2019

dboltovskyi Aug 13, 2019

Jack-Byrne Aug 12, 2019

dboltovskyi Aug 12, 2019 •

edited

Loading

dboltovskyi commented Aug 13, 2019

dboltovskyi commented Aug 14, 2019

Jack-Byrne commented Aug 14, 2019

dboltovskyi commented Aug 14, 2019

dboltovskyi commented Aug 15, 2019

dboltovskyi commented Aug 21, 2019

dboltovskyi commented Aug 23, 2019

dboltovskyi commented Aug 24, 2019

Feature/widget support #2218

Feature/widget support #2218

Conversation

mked-luxoft commented Jul 31, 2019 • edited Loading

Summary

ATF version

Manual checklist with screenshots

Changelog

Enhancements

Bug Fixes

CLA

AStasiuk commented Aug 5, 2019

Jack-Byrne Aug 12, 2019

Choose a reason for hiding this comment

dboltovskyi Aug 13, 2019

Choose a reason for hiding this comment

Jack-Byrne Aug 12, 2019

Choose a reason for hiding this comment

dboltovskyi Aug 12, 2019 • edited Loading

Choose a reason for hiding this comment

dboltovskyi commented Aug 13, 2019

dboltovskyi commented Aug 14, 2019

Jack-Byrne commented Aug 14, 2019

dboltovskyi commented Aug 14, 2019

dboltovskyi commented Aug 15, 2019

dboltovskyi commented Aug 21, 2019

dboltovskyi commented Aug 23, 2019

dboltovskyi commented Aug 24, 2019

mked-luxoft commented Jul 31, 2019 •

edited

Loading

dboltovskyi Aug 12, 2019 •

edited

Loading