Change implementation of to_row_vector for nalgebra #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morenol
force-pushed
the
lmm/nalgebra_to_row_vector
branch
from
8bdf7a2 to
bc4c9bc
Compare
VolodymyrOrlov
requested changes
Nov 24, 2020
morenol
force-pushed
the
lmm/nalgebra_to_row_vector
branch
from
bc4c9bc to
ff111f3
Compare
VolodymyrOrlov
approved these changes
Nov 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing the implementation of to_row_vector in nalgebra. It is now a reshape to (1, number of elements).
It was necessary an upgrade of the nalgebra crate in order to be able to use
reshape_generic.