Add benches for GNB #33
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morenol
force-pushed
the
lmm/gnb_bench
branch
from
316571e to
b73d742
Compare
VolodymyrOrlov
previously approved these changes
Dec 3, 2020
benches/naive_bayes.rs
Outdated
| n_samples, | ||
| |b, _| { | ||
| b.iter(|| { | ||
| GaussianNB::fit(&x, &y, Default::default()).unwrap(); |
There was a problem hiding this comment.
I do not really understand value of black_box but wondering, should we use it here for x and y. What do you think?
morenol
force-pushed
the
lmm/gnb_bench
branch
from
b73d742 to
e12d975
Compare
VolodymyrOrlov
approved these changes
Dec 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.