Roadmap to v0.5 #187

Mec-iS · 2022-10-13T18:54:47Z

These PR incorporates all the changes from #108 and all the fixes provided thereafter. So to allow a clear step-by-step plan to a new release (v0.5) that will provide all the improvements in #108 plus all the features implemented in the new traits system.

For a documentation of the process: #185

For a walkthrough starts from this branch's README.

EDIT:
This PR will include important breaking changes and cleanup. For example:

no more bindings for other numerical crates (probably)
no more support for "naive" DenseMatrix (only new DenseMatrix with num-traits)
Goodbye Matrix. Welcome Array2
Goodbye BaseVector. Welcome Array1
introduce use of trait-objects
...

cc: @NikZak @Steboss

…dimensional arrays

This reverts commit 782d77c.

Mec-iS · 2022-10-29T17:40:29Z

Some improvements in syscalls and CPU usage, much less alloc present as well

Mec-iS · 2022-10-29T17:42:00Z

@morenol please take a look to the wasm32 build and tests. I would like to exclude datasets from the wasm32 build and by consequence all the tests that use "datasets" or "make_blobs".

src/dataset/mod.rs

src/dataset/diabetes.rs

src/dataset/breast_cancer.rs

Co-authored-by: Luis Moreno <morenol@users.noreply.github.com>

morenol · 2022-10-29T18:42:50Z

I see that for wasm, failure is due to float eq implementation, let me check what I can do to solve that

  left: `[-2.001480000210124, -2.3581549441488563, -2.001480000210124, -2.6946271807700692, -2.224623551524334, -2.917770732084279, -2.10684051586795, -2.512305623976115, -2.6946271807700692, -2.001480000210124]`,
 right: `[-2.001480000210124, -2.3581549441488563, -2.001480000210124, -2.6946271807700692, -2.2246235515243336, -2.917770732084279, -2.10684051586795, -2.512305623976115, -2.6946271807700692, -2.001480000210124]`', src/naive_bayes/multinomial.rs:491:9

Mec-iS · 2022-10-29T18:44:38Z

I see that for wasm, failure is due to float eq implementation, let me check what I can do to solve that

  left: `[-2.001480000210124, -2.3581549441488563, -2.001480000210124, -2.6946271807700692, -2.224623551524334, -2.917770732084279, -2.10684051586795, -2.512305623976115, -2.6946271807700692, -2.001480000210124]`,
 right: `[-2.001480000210124, -2.3581549441488563, -2.001480000210124, -2.6946271807700692, -2.2246235515243336, -2.917770732084279, -2.10684051586795, -2.512305623976115, -2.6946271807700692, -2.001480000210124]`', src/naive_bayes/multinomial.rs:491:9

yes we will probably run into some differences in types for Wasm, we can also go and write dedicated tests.

* Fix tests * Add again removed line Co-authored-by: Luis Moreno <morenol@users.noreply.github.com>

…5-wip

…v0.5-wip

Mec-iS · 2022-10-30T19:58:21Z

Looked into some Cargo.toml settings:

resolver = "2"

[profile.test]
debug = 1
opt-level = 3
split-debuginfo = "unpacked"

[profile.release]
strip = true 
debug = 1
lto = true
codegen-units = 1
overflow-checks = true

* First draft of the new n-dimensional arrays + NB use case * Improves default implementation of multiple Array methods * Refactors tree methods * Adds matrix decomposition routines * Adds matrix decomposition methods to ndarray and nalgebra bindings * Refactoring + linear regression now uses array2 * Ridge & Linear regression * LBFGS optimizer & logistic regression * LBFGS optimizer & logistic regression * Changes linear methods, metrics and model selection methods to new n-dimensional arrays * Switches KNN and clustering algorithms to new n-d array layer * Refactors distance metrics * Optimizes knn and clustering methods * Refactors metrics module * Switches decomposition methods to n-dimensional arrays * Linalg refactoring - cleanup rng merge (#172) * Remove legacy DenseMatrix and BaseMatrix implementation. Port the new Number, FloatNumber and Array implementation into module structure. * Exclude AUC metrics. Needs reimplementation * Improve developers walkthrough New traits system in place at `src/numbers` and `src/linalg` Co-authored-by: Lorenzo <tunedconsulting@gmail.com> * Provide SupervisedEstimator with a constructor to avoid explicit dynamical box allocation in 'cross_validate' and 'cross_validate_predict' as required by the use of 'dyn' as per Rust 2021 * Implement getters to use as_ref() in src/neighbors * Implement getters to use as_ref() in src/naive_bayes * Implement getters to use as_ref() in src/linear * Add Clone to src/naive_bayes * Change signature for cross_validate and other model_selection functions to abide to use of dyn in Rust 2021 * Implement ndarray-bindings. Remove FloatNumber from implementations * Drop nalgebra-bindings support (as decided in conf-call to go for ndarray) * Remove benches. Benches will have their own repo at smartcore-benches * Implement SVC * Implement SVC serialization. Move search parameters in dedicated module * Implement SVR. Definitely too slow * Fix compilation issues for wasm (#202) Co-authored-by: Luis Moreno <morenol@users.noreply.github.com> * Fix tests (#203) * Port linalg/traits/stats.rs * Improve methods naming * Improve Display for DenseMatrix Co-authored-by: Montana Low <montanalow@users.noreply.github.com> Co-authored-by: VolodymyrOrlov <volodymyr.orlov@gmail.com>

Volodymyr Orlov and others added 30 commits May 31, 2021 12:19

First draft of the new n-dimensional arrays + NB use case

2c7fab0

Fixes formatting, adjusts methods signatures

09f5448

Improves default implementation of multiple Array methods

691c8a4

Refactors tree methods

d805877

Fixes benchmarks

aa86e3e

Adds matrix decomposition routines

2237746

Adds matrix decomposition methods to ndarray and nalgebra bindings

135b5ae

Refactoring + linear regression now uses array2

02da030

Ridge & Linear regression

dedd2f1

LBFGS optimizer & logistic regression

4e3cc72

LBFGS optimizer & logistic regression

fe30594

Changes linear methods, metrics and model selection methods to new n-…

4796098

…dimensional arrays

Switches KNN and clustering algorithms to new n-d array layer

8f1278d

Refactors distance metrics

e5190da

Optimizes knn and clustering methods

4836b6a

Refactors metrics module

7d07c1d

Switches decomposition methods to n-dimensional arrays

7f3bea3

Merge latest development branch

06b1a3d

Solve conflicts

dbce1ed

Resolve remaining conflicts

4072592

Solve other conflicts

23f8053

Fix first wave of compiler errors

7dcda3a

Fix compiler errrors for src/linear

95c59b8

Fix other compiler errors for src/linear

60065e6

Fix other calls. Exclude ensemble for now

782d77c

Remove documentation warnings

7f6eaa1

Revert "Fix other calls. Exclude ensemble for now"

8715934

This reverts commit 782d77c.

cargo fmt + remove nightly feature

b85e046

Fix some compilation errors

f48b5df

fix other compilation errors

5839bff

Mec-iS added 5 commits October 29, 2022 12:46

Fix doc tests. Move to Rust 2021

cc6ae8f

cargo clippy 100%

608841c

cargo fmt 100%

6c6b829

Cleanup tests

e1a4f6c

Apply formatting

a1d3cf9

morenol reviewed Oct 29, 2022

View reviewed changes

src/dataset/mod.rs Outdated Show resolved Hide resolved

morenol reviewed Oct 29, 2022

View reviewed changes

src/dataset/diabetes.rs Outdated Show resolved Hide resolved

morenol reviewed Oct 29, 2022

View reviewed changes

src/dataset/breast_cancer.rs Outdated Show resolved Hide resolved

Fix compilation issues for wasm (#202)

4cfa51e

Co-authored-by: Luis Moreno <morenol@users.noreply.github.com>

Fix tests (#203)

59e1420

* Fix tests * Add again removed line Co-authored-by: Luis Moreno <morenol@users.noreply.github.com>

Mec-iS marked this pull request as ready for review October 30, 2022 10:13

Mec-iS added 9 commits October 30, 2022 13:57

update .gitignore

4273176

Port linalg/traits/stats.rs

f3b97b6

Merge branch 'v0.5-wip' of github.com:smartcorelib/smartcore into v0.…

db60616

…5-wip

Merge branch 'development' of github.com:smartcorelib/smartcore into …

d208d97

…v0.5-wip

Fix tests

c702231

Improve methods naming

58e2e46

Improve Display for DenseMatrix

a020209

Add assertions to tests

24be152

Fix tests

850741f

Mec-iS added 2 commits October 31, 2022 10:17

fix linter

5922c8c

Add compiling options to Cargo

4f3632b

Mec-iS merged commit 52eb6ce into development Oct 31, 2022

Mec-iS deleted the v0.5-wip branch November 8, 2022 15:23

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Roadmap to v0.5 #187

Roadmap to v0.5 #187

Uh oh!

Mec-iS commented Oct 13, 2022 •

edited

Loading

Uh oh!

Mec-iS commented Oct 29, 2022 •

edited

Loading

Uh oh!

Mec-iS commented Oct 29, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

morenol commented Oct 29, 2022

Uh oh!

Mec-iS commented Oct 29, 2022

Uh oh!

Mec-iS commented Oct 30, 2022 •

edited

Loading

Uh oh!

Uh oh!

Roadmap to v0.5 #187

Roadmap to v0.5 #187

Uh oh!

Conversation

Mec-iS commented Oct 13, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Mec-iS commented Oct 29, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Mec-iS commented Oct 29, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

morenol commented Oct 29, 2022

Uh oh!

Mec-iS commented Oct 29, 2022

Uh oh!

Mec-iS commented Oct 30, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Mec-iS commented Oct 13, 2022 •

edited

Loading

Mec-iS commented Oct 29, 2022 •

edited

Loading

Mec-iS commented Oct 30, 2022 •

edited

Loading