Skip to content

Commit 4af6987

Browse files
authored
fix: Fix new clippy warnings (#79)
* Fix new clippy warnings * Allow clippy::suspicious-operation-groupings
1 parent 745d0b5 commit 4af6987

File tree

5 files changed

+7
-4
lines changed

5 files changed

+7
-4
lines changed

src/lib.rs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
11
#![allow(
22
clippy::type_complexity,
33
clippy::too_many_arguments,
4-
clippy::many_single_char_names
4+
clippy::many_single_char_names,
5+
clippy::unnecessary_wraps
56
)]
67
#![warn(missing_docs)]
78
#![warn(missing_doc_code_examples)]

src/linalg/mod.rs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
#![allow(clippy::wrong_self_convention)]
12
//! # Linear Algebra and Matrix Decomposition
23
//!
34
//! Most machine learning algorithms in SmartCore depend on linear algebra and matrix decomposition methods from this module.
@@ -265,7 +266,7 @@ pub trait BaseVector<T: RealNumber>: Clone + Debug {
265266
sum += xi * xi;
266267
}
267268
mu /= div;
268-
sum / div - mu * mu
269+
sum / div - mu.powi(2)
269270
}
270271
/// Computes the standard deviation.
271272
fn std(&self) -> T {

src/linalg/stats.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ pub trait MatrixStats<T: RealNumber>: BaseMatrix<T> {
6161
sum += a * a;
6262
}
6363
mu /= div;
64-
*x_i = sum / div - mu * mu;
64+
*x_i = sum / div - mu.powi(2);
6565
}
6666

6767
x

src/linear/lasso_optimizer.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -138,7 +138,7 @@ impl<T: RealNumber, M: Matrix<T>> InteriorPointOptimizer<T, M> {
138138

139139
for i in 0..p {
140140
self.prb[i] = T::two() + self.d1[i];
141-
self.prs[i] = self.prb[i] * self.d1[i] - self.d2[i] * self.d2[i];
141+
self.prs[i] = self.prb[i] * self.d1[i] - self.d2[i].powi(2);
142142
}
143143

144144
let normg = grad.norm2();

src/optimization/first_order/lbfgs.rs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
#![allow(clippy::suspicious_operation_groupings)]
12
use std::default::Default;
23
use std::fmt::Debug;
34

0 commit comments

Comments
 (0)