private_key to wallet_private_key#168
Open
naman1402 wants to merge 2 commits intosmartcontractkit:mainfrom
Open
private_key to wallet_private_key#168naman1402 wants to merge 2 commits intosmartcontractkit:mainfrom
naman1402 wants to merge 2 commits intosmartcontractkit:mainfrom
Conversation
Author
|
Kindly tag me, for feedback. |
Contributor
|
Hi @NamanMohnani , why do you want to update |
Author
|
Hello @QingyangKong , someone had this issue, and it caused confusion to differentiate it from other key. |
Contributor
|
Can you also check the config file and readme to update the name? |
Author
|
hey @QingyangKong I just made another commit as per requirements. Kindly review and give me a feedback and merge, if possible. |
nagrarohit
reviewed
Jun 1, 2023
nagrarohit
left a comment
nagrarohit
left a comment
There was a problem hiding this comment.
@NamanMohnani i dont think so , that it is creating any kind of confusion.
May be you should close this request.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed PRIVATE_KEY to WALLET_PRIVATE_KEY in .env.example to avoid confusions.