Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explicit DA oracle type to arbitrum and zksync chaintype configs #14835

Merged
merged 4 commits into from
Oct 17, 2024

Conversation

ogtownsend
Copy link
Collaborator

  • Arbitrum and ZKSync DA oracle types were not set causing l1_oracle NewL1GasOracle() to return an error
  • This PR sets these oracle types so we follow the existing oracle init logic

@ogtownsend ogtownsend requested review from a team as code owners October 17, 2024 18:38
Copy link
Contributor

github-actions bot commented Oct 17, 2024

AER Report: CI Core

aer_workflow , commit , Detect Changes , Clean Go Tidy & Generate , lint , Core Tests (go_core_tests) , Core Tests (go_core_ccip_deployment_tests) , Core Tests (go_core_race_tests) , Core Tests (go_core_fuzz) , SonarQube Scan

1. Test failures encountered:

  • TestNode panic: runtime error: invalid memory address or nil pointer dereference: [go_core_ccip_deployment_tests]

    Source of Error:
    panic: runtime error: invalid memory address or nil pointer dereference [recovered]
    panic: runtime error: invalid memory address or nil pointer dereference
    [signal SIGSEGV: segmentation violation code=0x1 addr=0x20 pc=0x1900a38]
    github.com/smartcontractkit/chainlink/v2/core/chains/evm/gas.NewEstimator({0x7f38fc8c25f8, 0xc002482cc0}, {0x7f38fc8c2d50, 0xc00247d540}, {0x0, 0x0}, {0x5103ce8, 0xc00209aa00})
    **Why**: This error is caused by a nil pointer dereference, which typically occurs when the code attempts to access a memory address that hasn't been initialized. **Suggested fix**: Ensure that all pointers are properly initialized before they are used. Add checks to verify that pointers are not nil before dereferencing them.
  • TestDeployCapabilityRegistry panic: runtime error: invalid memory address or nil pointer dereference: [go_core_ccip_deployment_tests]

    Source of Error:
    panic: runtime error: invalid memory address or nil pointer dereference [recovered]
    panic: runtime error: invalid memory address or nil pointer dereference
    [signal SIGSEGV: segmentation violation code=0x1 addr=0x20 pc=0x19402b8]
    github.com/smartcontractkit/chainlink/v2/core/chains/evm/gas.NewEstimator({0x7f9d04217f88, 0xc002ab6960}, {0x7f9d042186e0, 0xc002ab4140}, {0x0, 0x0}, {0x5128828, 0xc002827cc0})
    **Why**: This error is caused by a nil pointer dereference, which typically occurs when the code attempts to access a memory address that hasn't been initialized. **Suggested fix**: Ensure that all pointers are properly initialized before they are used. Add checks to verify that pointers are not nil before dereferencing them.
  • TestDeployChannelConfigStoreChangeSet panic: runtime error: invalid memory address or nil pointer dereference: [go_core_ccip_deployment_tests]

    Source of Error:
    panic: runtime error: invalid memory address or nil pointer dereference [recovered]
    panic: runtime error: invalid memory address or nil pointer dereference
    [signal SIGSEGV: segmentation violation code=0x1 addr=0x20 pc=0x190ed78]
    github.com/smartcontractkit/chainlink/v2/core/chains/evm/gas.NewEstimator({0x7fea4c29ae28, 0xc002068bd0}, {0x7fea4c29c5c8, 0xc00115f3c0}, {0x0, 0x0}, {0x511dee8, 0xc001dda8c0})
    **Why**: This error is caused by a nil pointer dereference, which typically occurs when the code attempts to access a memory address that hasn't been initialized. **Suggested fix**: Ensure that all pointers are properly initialized before they are used. Add checks to verify that pointers are not nil before dereferencing them.
  • TestDeployCCIPContracts panic: runtime error: invalid memory address or nil pointer dereference: [go_core_ccip_deployment_tests]

    Source of Error:
    panic: runtime error: invalid memory address or nil pointer dereference [recovered]
    panic: runtime error: invalid memory address or nil pointer dereference
    [signal SIGSEGV: segmentation violation code=0x1 addr=0x20 pc=0x42648f8]
    github.com/smartcontractkit/chainlink/v2/core/chains/evm/gas.NewEstimator({0x7f22581600c0, 0xc0034ffa70}, {0x7f2258160818, 0xc001fcec80}, {0x0, 0x0}, {0xa3f8ba8, 0xc001d1a8c0})
    **Why**: This error is caused by a nil pointer dereference, which typically occurs when the code attempts to access a memory address that hasn't been initialized. **Suggested fix**: Ensure that all pointers are properly initialized before they are used. Add checks to verify that pointers are not nil before dereferencing them.
  • TestInitialDeploy panic: runtime error: invalid memory address or nil pointer dereference: [go_core_ccip_deployment_tests]

    Source of Error:
    panic: runtime error: invalid memory address or nil pointer dereference [recovered]
    panic: runtime error: invalid memory address or nil pointer dereference
    [signal SIGSEGV: segmentation violation code=0x1 addr=0x20 pc=0x3fed458]
    github.com/smartcontractkit/chainlink/v2/core/chains/evm/gas.NewEstimator({0x7f9a20265dd0, 0xc002651ce0}, {0x7f9a20266508, 0xc0028876c0}, {0x0, 0x0}, {0x9c87c08, 0xc00266e500})
    **Why**: This error is caused by a nil pointer dereference, which typically occurs when the code attempts to access a memory address that hasn't been initialized. **Suggested fix**: Ensure that all pointers are properly initialized before they are used. Add checks to verify that pointers are not nil before dereferencing them.
  • TestIntegration_MercuryV1_Plugin panic: runtime error: invalid memory address or nil pointer dereference: [go_core_tests]

    Source of Error:
    panic: runtime error: invalid memory address or nil pointer dereference [recovered]
    panic: runtime error: invalid memory address or nil pointer dereference
    [signal SIGSEGV: segmentation violation code=0x1 addr=0x20 pc=0x19c7638]
    github.com/smartcontractkit/chainlink/v2/core/chains/evm/gas.NewEstimator({0x7f55ac603448, 0xc0025fcea0}, {0x7f55ac604430, 0xc0022ef7e0}, {0x0, 0x0}, {0x58ac978, 0xc001630500})
    **Why**: This error is caused by a nil pointer dereference, which typically occurs when the code attempts to access a memory address that hasn't been initialized. **Suggested fix**: Ensure that all pointers are properly initialized before they are used. Add checks to verify that pointers are not nil before dereferencing them.
  • TestIntegration_KeeperPluginConditionalUpkeep panic: runtime error: invalid memory address or nil pointer dereference: [go_core_tests]

    Source of Error:
    panic: runtime error: invalid memory address or nil pointer dereference [recovered]
    panic: runtime error: invalid memory address or nil pointer dereference
    [signal SIGSEGV: segmentation violation code=0x1 addr=0x20 pc=0x1c99738]
    github.com/smartcontractkit/chainlink/v2/core/chains/evm/gas.NewEstimator({0x7f7e889e4190, 0xc001903410}, {0x7f7e889e4e98, 0xc000dfe820}, {0x0, 0x0}, {0x58fc600, 0xc00186aa00})
    **Why**: This error is caused by a nil pointer dereference, which typically occurs when the code attempts to access a memory address that hasn't been initialized. **Suggested fix**: Ensure that all pointers are properly initialized before they are used. Add checks to verify that pointers are not nil before dereferencing them.
  • TestChainRelayExtenders panic: runtime error: invalid memory address or nil pointer dereference: [go_core_tests]

    Source of Error:
    panic: runtime error: invalid memory address or nil pointer dereference [recovered]
    panic: runtime error: invalid memory address or nil pointer dereference
    [signal SIGSEGV: segmentation violation code=0x1 addr=0x20 pc=0x13330b8]
    github.com/smartcontractkit/chainlink/v2/core/chains/evm/gas.NewEstimator({0x7f1940415b78, 0xc0034159b0}, {0x7f1940625aa8, 0xc002cc3d10}, {0x0, 0x0}, {0x5921ce0, 0xc002b88280})
    **Why**: This error is caused by a nil pointer dereference, which typically occurs when the code attempts to access a memory address that hasn't been initialized. **Suggested fix**: Ensure that all pointers are properly initialized before they are used. Add checks to verify that pointers are not nil before dereferencing them.
  • Test_PipelineRunner_ExecuteTaskRuns panic: runtime error: invalid memory address or nil pointer dereference: [go_core_tests]

    Source of Error:
    panic: runtime error: invalid memory address or nil pointer dereference [recovered]
    panic: runtime error: invalid memory address or nil pointer dereference
    [signal SIGSEGV: segmentation violation code=0x1 addr=0x20 pc=0x1362478]
    github.com/smartcontractkit/chainlink/v2/core/chains/evm/gas.NewEstimator({0x7efe301a78d8, 0xc0020dd8c0}, {0x7efe301a7ed8, 0xc002039b90}, {0x0, 0x0}, {0x42b6eb0, 0xc0005f5900})
    **Why**: This error is caused by a nil pointer dereference, which typically occurs when the code attempts to access a memory address that hasn't been initialized. **Suggested fix**: Ensure that all pointers are properly initialized before they are used. Add checks to verify that pointers are not nil before dereferencing them.
  • TestDelegate_ReorgAttackProtection panic: runtime error: invalid memory address or nil pointer dereference: [go_core_tests]

    Source of Error:
    panic: runtime error: invalid memory address or nil pointer dereference [recovered]
    panic: runtime error: invalid memory address or nil pointer dereference
    [signal SIGSEGV: segmentation violation code=0x1 addr=0x20 pc=0x10a6e38]
    github.com/smartcontractkit/chainlink/v2/core/chains/evm/gas.NewEstimator({0x7f8038686470, 0xc0011ed500}, {0x7f80385e1fb0, 0xc000a7fea0}, {0x0, 0x0}, {0x4201568, 0xc001518dc0})
    **Why**: This error is caused by a nil pointer dereference, which typically occurs when the code attempts to access a memory address that hasn't been initialized. **Suggested fix**: Ensure that all pointers are properly initialized before they are used. Add checks to verify that pointers are not nil before dereferencing them.
  • TestIntegration_VRF_WithBHS panic: runtime error: invalid memory address or nil pointer dereference: [go_core_tests]

    Source of Error:
    panic: runtime error: invalid memory address or nil pointer dereference [recovered]
    panic: runtime error: invalid memory address or nil pointer dereference
    [signal SIGSEGV: segmentation violation code=0x1 addr=0x20 pc=0x129dd18]
    github.com/smartcontractkit/chainlink/v2/core/chains/evm/gas.NewEstimator({0x7f5f486241b8, 0xc001a3b9b0}, {0x7f5f48624d50, 0xc0029023a0}, {0x0, 0x0}, {0x5759498, 0xc002837400})
    **Why**: This error is caused by a nil pointer dereference, which typically occurs when the code attempts to access a memory address that hasn't been initialized. **Suggested fix**: Ensure that all pointers are properly initialized before they are used. Add checks to verify that pointers are not nil before dereferencing them.
  • TestVRFV2PlusIntegration_SingleConsumer_BigGasCallback_Sandwich panic: runtime error: invalid memory address or nil pointer dereference: [go_core_tests]

    Source of Error:
    panic: runtime error: invalid memory address or nil pointer dereference [recovered]
    panic: runtime error: invalid memory address or nil pointer dereference
    [signal SIGSEGV: segmentation violation code=0x1 addr=0x20 pc=0x12f3358]
    github.com/smartcontractkit/chainlink/v2/core/chains/evm/gas.NewEstimator({0x7f36fc53a150, 0xc002f220c0}, {0x7f36fc492ae0, 0xc001137940}, {0x0, 0x0}, {0x58cb3e0, 0xc0022c88c0})
    **Why**: This error is caused by a nil pointer dereference, which typically occurs when the code attempts to access a memory address that hasn't been initialized. **Suggested fix**: Ensure that all pointers are properly initialized before they are used. Add checks to verify that pointers are not nil before dereferencing them.
  • Test_FeaturesController_List panic: runtime error: invalid memory address or nil pointer dereference: [go_core_tests]

    Source of Error:
    panic: runtime error: invalid memory address or nil pointer dereference [recovered]
    panic: runtime error: invalid memory address or nil pointer dereference
    [signal SIGSEGV: segmentation violation code=0x1 addr=0x20 pc=0x173e258]
    github.com/smartcontractkit/chainlink/v2/core/chains/evm/gas.NewEstimator({0x7fc5d4f9d118, 0xc001ab6c30}, {0x7fc5ee377a68, 0xc000cf2228}, {0x0, 0x0}, {0x58dbc68, 0xc0018c6500})
    **Why**: This error is caused by a nil pointer dereference, which typically occurs when the code attempts to access a memory address that hasn't been initialized. **Suggested fix**: Ensure that all pointers are properly initialized before they are used. Add checks to verify that pointers are not nil before dereferencing them.

AER Report: Operator UI CI ran successfully ✅

aer_workflow , commit

@ogtownsend ogtownsend force-pushed the add-da-oracle-type-to-arbitrum-and-zkysnc-configs branch from 9b37dbf to 094bd8d Compare October 17, 2024 18:59
Copy link
Contributor

github-actions bot commented Oct 17, 2024

AER Report: CI Core ran successfully ✅

aer_workflow , commit

AER Report: Operator UI CI ran successfully ✅

aer_workflow , commit

@ogtownsend ogtownsend requested a review from a team as a code owner October 17, 2024 19:06
jmank88
jmank88 previously approved these changes Oct 17, 2024
@ogtownsend ogtownsend changed the title Add explicit DA oracle type to arbitrum and zksync chaintype configs Add explicit DA oracle type to arbitrum and zksync chain configs Oct 17, 2024
@ogtownsend ogtownsend changed the title Add explicit DA oracle type to arbitrum and zksync chain configs Add explicit DA oracle type to arbitrum and zksync chaintype configs Oct 17, 2024
@krehermann krehermann added the build-publish Build and Publish image to SDLC label Oct 17, 2024
@krehermann krehermann enabled auto-merge October 17, 2024 21:19
@krehermann krehermann added this pull request to the merge queue Oct 17, 2024
Merged via the queue into develop with commit 468fc4c Oct 17, 2024
150 of 151 checks passed
@krehermann krehermann deleted the add-da-oracle-type-to-arbitrum-and-zkysnc-configs branch October 17, 2024 21:35
@Madalosso
Copy link
Contributor

Is there an ongoing effort to replicate these changes on CCIP repo chain configs as well?
cc @friedemannf @simsonraj

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build-publish Build and Publish image to SDLC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants