Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unreferenced unused key files. #14706

Merged
merged 6 commits into from
Oct 18, 2024

Conversation

pavel-raykov
Copy link
Collaborator

@pavel-raykov pavel-raykov commented Oct 9, 2024

Trying to remove unused files BCF-3414.

Copy link
Contributor

github-actions bot commented Oct 9, 2024

WF: CI Core#972a527

No errors found in this run. 🎉

@pavel-raykov pavel-raykov marked this pull request as ready for review October 10, 2024 14:30
@pavel-raykov pavel-raykov requested a review from a team as a code owner October 10, 2024 14:30
Copy link
Collaborator

@samsondav samsondav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's probably been long enough now that this is safe to remove. You might consider deleting the old table as well.

Copy link
Contributor

@RyanRHall RyanRHall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 to @samsondav - I would suggest we delete the old tables too

Copy link
Contributor

github-actions bot commented Oct 17, 2024

AER Report: CI Core ran successfully ✅

aer_workflow , commit

AER Report: Operator UI CI ran successfully ✅

aer_workflow , commit

@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@pavel-raykov pavel-raykov added this pull request to the merge queue Oct 18, 2024
Merged via the queue into develop with commit f7abc3e Oct 18, 2024
128 checks passed
@pavel-raykov pavel-raykov deleted the BCF-3414-Remove-obsolete-code branch October 18, 2024 07:02
winder pushed a commit that referenced this pull request Oct 21, 2024
* Remove unreferenced unused key files.

* Add changeset.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants