Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add getNextDONId and getNodesByP2PIds Functions and define ICapabilitiesRegistry Interface #14696

Merged
merged 33 commits into from
Oct 21, 2024
Merged

Add getNextDONId and getNodesByP2PIds Functions and define ICapabilitiesRegistry Interface #14696

merged 33 commits into from
Oct 21, 2024

Conversation

0xsuryansh
Copy link
Member

@0xsuryansh 0xsuryansh commented Oct 9, 2024 •
edited
Loading

Description:

This PR introduces the getNextDONId and getNodesByP2PIds functions to the CapabilitiesRegistry contract. Additionally, it defines the INodeInfoProvider interface to abstract node information retrieval functionality and ensure consistency for calling contracts.

Key Changes:

  1. New Functions:

    • getNextDONId : Returns the ID of the next Decentralized Oracle Network (DON) to be assigned.
    • getNodesByP2PIds : Retrieves details of all registered nodes or specific nodes based on their p2pId.

  2. INodeInfoProvider Interface:

    • Provides function signatures, struct, event and error definitions for fetching node info

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 9, 2024 •
edited
Loading

Static analysis results are available

Hey @0xsuryansh, you can view Slither reports in the job summary here or download them as artifact here.

Please check them before merging and make sure you have addressed all issues.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 9, 2024 •
edited
Loading

WF: CI Core#036edc7

No errors found in this run. 🎉

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 9, 2024 •
edited
Loading

WF: CI Core#5cc8f9f

No errors found in this run. 🎉

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 9, 2024 •
edited
Loading

WF: CI Core#90d5e5a

No errors found in this run. 🎉

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 9, 2024 •
edited
Loading

WF: CI Core#de42d75

No errors found in this run. 🎉

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 10, 2024 •
edited
Loading

WF: CI Core#62c9ca0

No errors found in this run. 🎉

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 10, 2024 •
edited
Loading

WF: CI Core#459247f

No errors found in this run. 🎉

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 10, 2024 •
edited
Loading

WF: CI Core#42a4b86

No errors found in this run. 🎉

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 10, 2024 •
edited
Loading

WF: CI Core#f723686

No errors found in this run. 🎉

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 10, 2024 •
edited
Loading

WF: CI Core#a6e7955

No errors found in this run. 🎉

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 10, 2024 •
edited
Loading

WF: CI Core#c9a5a30

No errors found in this run. 🎉

@0xsuryansh 0xsuryansh changed the title feat: add getNextDonId and batch getNodes getter Add CapabilitiesRegistry Interface with Events and Function Signatures and new getters Oct 10, 2024
@0xsuryansh 0xsuryansh changed the title Add CapabilitiesRegistry Interface with Events and Function Signatures and new getters Add getNextDONId and getNodes Functions with Unit Tests and ICapabilitiesRegistry Interface Oct 10, 2024
@0xsuryansh 0xsuryansh changed the title Add getNextDONId and getNodes Functions with Unit Tests and ICapabilitiesRegistry Interface Add getNextDONId and getNodes Functions and define ICapabilitiesRegistry Interface Oct 10, 2024
@0xsuryansh 0xsuryansh changed the title Add getNextDONId and getNodes Functions and define ICapabilitiesRegistry Interface Add getNextDONId and getNodes Functions and define ICapabilitiesRegistry Interface Oct 10, 2024
@0xsuryansh 0xsuryansh marked this pull request as ready for review October 10, 2024 09:59
@0xsuryansh 0xsuryansh requested review from a team as code owners October 10, 2024 09:59
DeividasK
DeividasK previously approved these changes Oct 18, 2024
View reviewed changes
makramkd
makramkd previously approved these changes Oct 18, 2024
View reviewed changes
@0xsuryansh 0xsuryansh requested a review from a team as a code owner October 18, 2024 10:11
@0xsuryansh 0xsuryansh dismissed stale reviews from DeividasK and makramkd via 989104f October 18, 2024 10:30
@0xsuryansh 0xsuryansh requested review from RensR, makramkd and DeividasK and removed request for RensR October 18, 2024 10:36
@0xsuryansh
Merge branch 'develop' into CCIP-3149_keystone_capability_registry_ge…
d4b356b 
…tters_interface

# Conflicts:
#	core/gethwrappers/ccip/generation/generated-wrapper-dependency-versions-do-not-edit.txt
@0xsuryansh
fix wrapper
72d290a
@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@RensR RensR enabled auto-merge October 21, 2024 15:39
@RensR RensR added this pull request to the merge queue Oct 21, 2024
Merged via the queue into develop with commit 072bfb6 Oct 21, 2024
166 of 167 checks passed
@RensR RensR deleted the feat/keystone_capability_registry_getters branch October 21, 2024 15:55
This was referenced Oct 21, 2024
Draft
Draft
Draft
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinkaseman justinkaseman justinkaseman approved these changes

@patrickhuie19 patrickhuie19 patrickhuie19 approved these changes

@DeividasK DeividasK DeividasK approved these changes

@makramkd makramkd makramkd approved these changes

@RensR RensR RensR approved these changes

@winder winder Awaiting requested review from winder winder is a code owner automatically assigned from smartcontractkit/ccip-offchain

@rstout rstout Awaiting requested review from rstout rstout is a code owner automatically assigned from smartcontractkit/ccip-offchain

@asoliman92 asoliman92 Awaiting requested review from asoliman92 asoliman92 is a code owner automatically assigned from smartcontractkit/ccip-offchain

@dimkouv dimkouv Awaiting requested review from dimkouv dimkouv is a code owner automatically assigned from smartcontractkit/ccip-offchain

@mateusz-sekara mateusz-sekara Awaiting requested review from mateusz-sekara mateusz-sekara is a code owner automatically assigned from smartcontractkit/ccip-offchain

@0xnogo 0xnogo Awaiting requested review from 0xnogo 0xnogo is a code owner automatically assigned from smartcontractkit/ccip-offchain

@george-dorin george-dorin Awaiting requested review from george-dorin george-dorin is a code owner automatically assigned from smartcontractkit/foundations

@matYang matYang Awaiting requested review from matYang

@RayXpub RayXpub Awaiting requested review from RayXpub

@elatoskinas elatoskinas Awaiting requested review from elatoskinas

@jhweintraub jhweintraub Awaiting requested review from jhweintraub

@RyanRHall RyanRHall Awaiting requested review from RyanRHall

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@0xsuryansh @RensR @makramkd @DeividasK @patrickhuie19 @justinkaseman