Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roll forward add wasm spec factory (#14458) #14687

Merged
merged 5 commits into from
Oct 8, 2024
Merged

Conversation

nolag
Copy link
Contributor

@nolag nolag commented Oct 8, 2024

No description provided.

* Add wasm spec factory

* Fix workflow tests

* Fix and test spec validation for non-YAML specs

* Revert use of logger in validate

* tidy and reorder inputs

* brotli the WASM so it's smaller for the sdk to pass around

* Fix so sum is always based on wasm not encoded value

* Fix typo and lint imports in wasm file spec factory

* Fix sha sum on wasm

* Fix go mod merge conflict :(

* Fix lint and remove local hack for go version...
@nolag nolag requested review from a team as code owners October 8, 2024 16:41
@nolag nolag requested a review from jmank88 October 8, 2024 16:41
Copy link
Contributor

github-actions bot commented Oct 8, 2024

WF: CI Core#ed3d28f

No errors found in this run. 🎉

@nolag nolag enabled auto-merge October 8, 2024 16:51
@nolag nolag force-pushed the rtinianov_roll_forward_wasm branch from d31a301 to ed3d28f Compare October 8, 2024 17:02
Copy link
Contributor

github-actions bot commented Oct 8, 2024

WF: CI Core#153026e

No errors found in this run. 🎉

Copy link
Contributor

github-actions bot commented Oct 8, 2024

WF: CI Core#a39382b

No errors found in this run. 🎉

Copy link
Contributor

@winder winder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why CCIP isi gating this

@nolag nolag added this pull request to the merge queue Oct 8, 2024
Merged via the queue into develop with commit 910e65f Oct 8, 2024
129 of 130 checks passed
@nolag nolag deleted the rtinianov_roll_forward_wasm branch October 8, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants