-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Roll forward add wasm spec factory (#14458) #14687
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add wasm spec factory * Fix workflow tests * Fix and test spec validation for non-YAML specs * Revert use of logger in validate * tidy and reorder inputs * brotli the WASM so it's smaller for the sdk to pass around * Fix so sum is always based on wasm not encoded value * Fix typo and lint imports in wasm file spec factory * Fix sha sum on wasm * Fix go mod merge conflict :( * Fix lint and remove local hack for go version...
WF: CI Core#ed3d28fNo errors found in this run. 🎉 |
nolag
force-pushed
the
rtinianov_roll_forward_wasm
branch
from
October 8, 2024 17:02
d31a301
to
ed3d28f
Compare
WF: CI Core#153026eNo errors found in this run. 🎉 |
WF: CI Core#a39382bNo errors found in this run. 🎉 |
jmank88
approved these changes
Oct 8, 2024
cedric-cordenier
approved these changes
Oct 8, 2024
Quality Gate passedIssues Measures |
winder
approved these changes
Oct 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure why CCIP isi gating this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.