Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Json schema for the webapi trigger #14627

Merged
merged 9 commits into from
Oct 3, 2024
Merged

Json schema for the webapi trigger #14627

merged 9 commits into from
Oct 3, 2024

Conversation

nolag
Copy link
Contributor

@nolag nolag commented Oct 1, 2024

No description provided.

@nolag nolag requested review from a team as code owners October 1, 2024 19:37
@nolag nolag requested review from ilija42 and removed request for a team October 1, 2024 19:37
@nolag nolag enabled auto-merge October 1, 2024 19:57
Copy link
Contributor

github-actions bot commented Oct 1, 2024

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

🎖️ No JIRA issue number found in: PR title, commit message, or branch name. Please include the issue ID in one of these.

@@ -0,0 +1,5 @@
package webapicap
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be the package for all the webapi capabilities, notably the trigger and the target? We seem to have 3 different package names in the handler now.
webapicap
trigger
target
And also webapicapabilities in gateway.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know who uses webapicapabilities, but if it's only for these capabilities, it should have the duplicated types removed in favour of these ones.

webapicap should hold the wasm builders for both the trigger and the target IMO.

The trigger and target can either be in the webapi folder, or subfolders called trigger and target. I'm less opinonated about that one. @DeividasK has probably put more thought into it.

@DavidOrchard DavidOrchard requested review from a team as code owners October 3, 2024 18:33
@cl-sonarqube-production
Copy link

Quality Gate failed Quality Gate failed

Failed conditions
13.6% Duplication on New Code (required ≤ 10%)

See analysis details on SonarQube

@nolag nolag added this pull request to the merge queue Oct 3, 2024
Merged via the queue into develop with commit fdbd9da Oct 3, 2024
128 of 130 checks passed
@nolag nolag deleted the rtinianov_webabischema branch October 3, 2024 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants