-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Json schema for the webapi trigger #14627
Conversation
I see you updated files related to
|
@@ -0,0 +1,5 @@ | |||
package webapicap |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this be the package for all the webapi capabilities, notably the trigger and the target? We seem to have 3 different package names in the handler now.
webapicap
trigger
target
And also webapicapabilities in gateway.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know who uses webapicapabilities, but if it's only for these capabilities, it should have the duplicated types removed in favour of these ones.
webapicap should hold the wasm builders for both the trigger and the target IMO.
The trigger and target can either be in the webapi folder, or subfolders called trigger and target. I'm less opinonated about that one. @DeividasK has probably put more thought into it.
Quality Gate failedFailed conditions |
No description provided.