Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change KeystoneForwarder routing gas accounting #14543

Merged
merged 13 commits into from
Sep 25, 2024
Merged

Change KeystoneForwarder routing gas accounting #14543

merged 13 commits into from
Sep 25, 2024

Conversation

DeividasK
Copy link
Collaborator

@DeividasK DeividasK commented Sep 24, 2024 •
edited
Loading

  • Fixing Go lint issues and incorrect WriteTarget interface check.
  • Adding additional tests for KeystoneForwarder.

@DeividasK DeividasK requested a review from a team as a code owner September 24, 2024 11:53
@DeividasK DeividasK requested a review from a team as a code owner September 24, 2024 12:17
@DeividasK DeividasK requested review from george-dorin and removed request for a team September 24, 2024 12:17
archseer
archseer previously approved these changes Sep 25, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 25, 2024 •
edited
Loading

Static analysis results are available

Hey @DeividasK, you can view Slither reports in the job summary here or download them as artifact here.

Please check them before merging and make sure you have addressed all issues.

@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
50.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@DeividasK DeividasK changed the title Add additional KeystoneForwarder tests with malicious receivers Change KeystoneForwarder routing gas accounting Sep 25, 2024
@DeividasK DeividasK added this pull request to the merge queue Sep 25, 2024
Merged via the queue into develop with commit c4fa565 Sep 25, 2024
143 of 146 checks passed
@DeividasK DeividasK deleted the dk-bump-gas-for-routing branch September 25, 2024 13:51
@github-actions github-actions bot mentioned this pull request Sep 25, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cedric-cordenier cedric-cordenier cedric-cordenier approved these changes

@archseer archseer archseer approved these changes

@george-dorin george-dorin Awaiting requested review from george-dorin george-dorin is a code owner automatically assigned from smartcontractkit/foundations

@RensR RensR Awaiting requested review from RensR

@matYang matYang Awaiting requested review from matYang

@RayXpub RayXpub Awaiting requested review from RayXpub

@elatoskinas elatoskinas Awaiting requested review from elatoskinas

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DeividasK @archseer @cedric-cordenier