Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update AutoPurge config interface and add header for Scroll API #13999

Merged
merged 4 commits into from
Aug 2, 2024

Conversation

amit-momin
Copy link
Contributor

@amit-momin amit-momin commented Aug 1, 2024

BCI-3906

  • Updated the AutoPurge.Threshold and AutoPurge.MinAttempts configs to be optional since they are only required for the heuristic
  • Added the Content-Type: application/json header for the Scroll API

@amit-momin amit-momin changed the title Fix/stuck tx detector scroll api Update AutoPurge config interface and add header for Scroll API Aug 1, 2024
@amit-momin amit-momin marked this pull request as ready for review August 1, 2024 22:05
@amit-momin amit-momin requested review from a team as code owners August 1, 2024 22:05
Copy link
Contributor

@Farber98 Farber98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dimriou dimriou added this pull request to the merge queue Aug 2, 2024
Merged via the queue into develop with commit 2a032e8 Aug 2, 2024
119 checks passed
@dimriou dimriou deleted the fix/stuck-tx-detector-scroll-api branch August 2, 2024 15:52
Tofel pushed a commit that referenced this pull request Aug 5, 2024
* Updated AutoPurge heuristic configs to be optional

* Added content-type header for Scroll stuck tx API call

* Fixed linting

* Added changeset
asoliman92 pushed a commit that referenced this pull request Aug 28, 2024
* Updated AutoPurge heuristic configs to be optional

* Added content-type header for Scroll stuck tx API call

* Fixed linting

* Added changeset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants