Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auto-11214: migrate more tests to foundry #13934

Merged
merged 13 commits into from
Aug 7, 2024

Conversation

FelixFan1992
Copy link
Contributor

Requires Dependencies

Resolves Dependencies

Copy link
Contributor

github-actions bot commented Aug 2, 2024

LCOV of commit 4005c8c during Solidity Foundry #41216

Summary coverage rate:
  lines......: 98.7% (1838 of 1862 lines)
  functions..: 96.6% (344 of 356 functions)
  branches...: 90.7% (782 of 862 branches)

Files changed coverage rate: n/a

@FelixFan1992 FelixFan1992 changed the title auto: migrate more tests to foundry auto-11214: migrate more tests to foundry Aug 2, 2024
@FelixFan1992 FelixFan1992 marked this pull request as ready for review August 2, 2024 19:48
@FelixFan1992 FelixFan1992 requested a review from a team as a code owner August 2, 2024 19:48
@FelixFan1992 FelixFan1992 requested review from a team, infiloop2 and RyanRHall and removed request for a team August 2, 2024 19:48
ibrajer
ibrajer previously approved these changes Aug 7, 2024
Copy link
Contributor

@RyanRHall RyanRHall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow great job converting all these @FelixFan1992 💪 🎉

@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Copy link
Contributor

@RyanRHall RyanRHall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@FelixFan1992 FelixFan1992 added this pull request to the merge queue Aug 7, 2024
Merged via the queue into develop with commit 2ac9d98 Aug 7, 2024
118 checks passed
@FelixFan1992 FelixFan1992 deleted the registry-foundry-test-migration branch August 7, 2024 22:58
momentmaker added a commit that referenced this pull request Aug 8, 2024
* develop:
  CRIB CI integration (#13924)
  fix: refactor sonarqube scan args (#13875)
  BCI-3492 [LogPoller]: Allow withObservedExecAndRowsAffected to report non-zero rows affected (#14057)
  Add error mapping for Astar (#13990)
  [BCI-3862][chainlink] - Change DSL Block primitive to string instead of int (#14033)
  [KS-412] Validate called DON membership in TriggerPublisher (#14040)
  [TT-1429] notifying guardian on some failures (#14073)
  Add Mantle errors (#14053)
  Fix write target nil dereferences (#14059)
  Allow retrying failed transmissions (#14017)
  auto-11214: migrate more tests to foundry (#13934)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants